Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62806

active-choices plugin may break with tables-to-divs

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The active-choices plugin implements custom markup similar to the one of the f:checkbox widget that may break with the tables-to-divs changes: https://github.com/jenkinsci/active-choices-plugin/blob/9d26c1159205e0e7affdedb8b210c84dc6266e4d/src/main/resources/org/biouno/unochoice/common/checkboxContent.jelly

      It should be reviewed and fixed if needed.

        Attachments

          Issue Links

            Activity

            Hide
            kinow Bruno P. Kinoshita added a comment -

            Hi Félix Queiruga Balado,

            Thanks for reporting the issue. I wasn't aware of the migration, but found this page: https://www.jenkins.io/doc/developer/views/table-to-div-migration/

            In one of the paragraphs, it says:

            >For 99% of plugins they do not require any changes at all as they just use the standard jelly tags in Jenkins for their forms, such as f:entry, f:textbox, f:checkbox

            So f:checkbox should be OK I guess.

            But we are using tr/td, and also doing some custom JS code. So we may have to update some of our code once JENKINS-56109 gets merged/released.

            Linking the issue here for now

            Show
            kinow Bruno P. Kinoshita added a comment - Hi Félix Queiruga Balado , Thanks for reporting the issue. I wasn't aware of the migration, but found this page: https://www.jenkins.io/doc/developer/views/table-to-div-migration/ In one of the paragraphs, it says: >For 99% of plugins they do not require any changes at all as they just use the standard jelly tags in Jenkins for their forms, such as f:entry, f:textbox, f:checkbox So f:checkbox should be OK I guess. But we are using tr/td, and also doing some custom JS code. So we may have to update some of our code once JENKINS-56109 gets merged/released. Linking the issue here for now
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            I'd suggest to maybe use the `divBasedFormLayout` variable to conditionally load / run the proper JS code. Let us know if you find any issue.

            Show
            fqueiruga Félix Queiruga Balado added a comment - I'd suggest to maybe use the `divBasedFormLayout` variable to conditionally load / run the proper JS code. Let us know if you find any issue.
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            Bruno P. Kinoshita these changes has been released as of Jenkins 2.264 a week ago, so the plugin may be affected ever since.

            Show
            fqueiruga Félix Queiruga Balado added a comment - Bruno P. Kinoshita these changes has been released as of Jenkins 2.264 a week ago, so the plugin may be affected ever since.
            Hide
            kinow Bruno P. Kinoshita added a comment -

            Thanks Félix Queiruga Balado ! I'm busy with other projects, but will have a break in December/January. But I suspect the plug-in will stay broken with 2.264+ for a little while (probably Q1/2021). cc Ioannis Moutsatsos

            Show
            kinow Bruno P. Kinoshita added a comment - Thanks Félix Queiruga Balado ! I'm busy with other projects, but will have a break in December/January. But I suspect the plug-in will stay broken with 2.264+ for a little while (probably Q1/2021). cc Ioannis Moutsatsos

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              fqueiruga Félix Queiruga Balado
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: