Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62808

PCT: pipeline-model-definition plugin may break with tables-to-divs

    XMLWordPrintable

    Details

    • Similar Issues:

      Attachments

        Activity

        Hide
        timja Tim Jacomb added a comment -

        Checked all of the above and they all seem fine,

        It's snippet generation and quite isolated

        Show
        timja Tim Jacomb added a comment - Checked all of the above and they all seem fine, It's snippet generation and quite isolated
        Hide
        fqueiruga Félix Queiruga Balado added a comment - - edited

        We found PCT errors on this plugin when running automated tests against the tables-to-divs branch:

        • org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.parametersInInput
        • org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.singleParameterInInput
        Show
        fqueiruga Félix Queiruga Balado added a comment - - edited We found PCT errors on this plugin when running automated tests against the tables-to-divs branch: org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.parametersInInput org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.singleParameterInInput
        Hide
        timja Tim Jacomb added a comment -

        Not an issue with production code just selectors in unit tests

        Show
        timja Tim Jacomb added a comment - Not an issue with production code just selectors in unit tests
        Hide
        mramonleon Ramon Leon added a comment -

        I still consider this ticket valid. We could change the type or the affected component, but it's still an issue when running tests on PCT.

        Show
        mramonleon Ramon Leon added a comment - I still consider this ticket valid. We could change the type or the affected component, but it's still an issue when running tests on PCT.
        Hide
        timja Tim Jacomb added a comment -

        Is there a specific reason you re-opened this Ramon Leon, the ticket was closed because the PR was merged (https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/402)

        Show
        timja Tim Jacomb added a comment - Is there a specific reason you re-opened this Ramon Leon , the ticket was closed because the PR was merged ( https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/402 )
        Hide
        mramonleon Ramon Leon added a comment -

        I reopened it by mistake Tim Jacomb Didn't realize it was fixed with this PR even though it was PCT errors. I understood you closed it because it was not a production bug. Sorry for the noise.

        Show
        mramonleon Ramon Leon added a comment - I reopened it by mistake Tim Jacomb Didn't realize it was fixed with this PR even though it was PCT errors. I understood you closed it because it was not a production bug. Sorry for the noise.

          People

          Assignee:
          Unassigned Unassigned
          Reporter:
          fqueiruga Félix Queiruga Balado
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: