Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: pipeline-model-definition-plugin
-
Labels:None
-
Similar Issues:
-
Epic Link:
Description
The pipeline-model-definitions plugin contains forks of jelly widgets that may break with the form tables-to-divs changes:
It also contains tabular markup within forms in the following files:
- https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/EnvironmentDirective/config.jelly
- https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/LibrariesDirective/config.jelly
- https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/DirectiveGenerator/index.jelly
It should be reviewed and fixed if needed.
Attachments
Issue Links
Activity
We found PCT errors on this plugin when running automated tests against the tables-to-divs branch:
- org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.parametersInInput
- org.jenkinsci.plugins.pipeline.modeldefinition.StageInputTest.singleParameterInInput
Not an issue with production code just selectors in unit tests
I still consider this ticket valid. We could change the type or the affected component, but it's still an issue when running tests on PCT.
Is there a specific reason you re-opened this Ramon Leon, the ticket was closed because the PR was merged (https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/402)
I reopened it by mistake Tim Jacomb Didn't realize it was fixed with this PR even though it was PCT errors. I understood you closed it because it was not a production bug. Sorry for the noise.
Checked all of the above and they all seem fine,
It's snippet generation and quite isolated