Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62813

Update Pipeline library retriever config to match new layout

    • 2.20

      The redesign in JENKINS-56109 may obviate the need for JENKINS-38712. We should try reverting that change (while retaining the help text it added) and see if the result looks reasonable.

          [JENKINS-62813] Update Pipeline library retriever config to match new layout

          Most of the work we did to improve the visualization of nested content was actually done with this very interaction in mind. There's always the chance to improve it so we are really open to suggestions.

           

          Félix Queiruga Balado added a comment - Most of the work we did to improve the visualization of nested content was actually done with this very interaction in mind. There's always the chance to improve it so we are really open to suggestions.  

          Oleg Nenashev added a comment - - edited

          Once https://github.com/jenkinsci/jenkins/pull/4820 is released, the issue will appear in UIs for Jenkins users

          Oleg Nenashev added a comment - - edited Once  https://github.com/jenkinsci/jenkins/pull/4820  is released, the issue will appear in UIs for Jenkins users

          Jesse Glick added a comment -

          To be clear, as far as I know the core change does not make anything worse for this screen. Rather, the point of this issue is that it may enable us to go back to more straightforward and intuitive control structure without putting up with ridiculously deep indentation, the motivation for the hack done in JENKINS-38712.

          Jesse Glick added a comment - To be clear, as far as I know the core change does not make anything worse for this screen. Rather, the point of this issue is that it may enable us to go back to more straightforward and intuitive control structure without putting up with ridiculously deep indentation, the motivation for the hack done in JENKINS-38712 .

          jglick now that the form changes have been released in 2.264, do you know if this affects any screens? If so, what repos may be affected? I can do a code search in those repos and report the individual findings.

           

          Félix Queiruga Balado added a comment - jglick now that the form changes have been released in 2.264, do you know if this affects any screens? If so, what repos may be affected? I can do a code search in those repos and report the individual findings.  

          Jesse Glick added a comment -

          fqueiruga not sure I understand the question. This is just about simplifying the GUI config screen for Groovy libraries to use an intuitive block structure like it did originally, rather than nested radio buttons like we were forced to use in order to avoid deep indentation when using tables.

          Jesse Glick added a comment - fqueiruga not sure I understand the question. This is just about simplifying the GUI config screen for Groovy libraries to use an intuitive block structure like it did originally, rather than nested radio buttons like we were forced to use in order to avoid deep indentation when using tables.

          Ah, I see. So we shouldn't include it in the tables-to-divs regression epic right?

          Félix Queiruga Balado added a comment - Ah, I see. So we shouldn't include it in the tables-to-divs regression epic right?

          Josh Soref added a comment -

          Right, it's not a regression, it's an opportunity to partially revert a hack.

          Josh Soref added a comment - Right, it's not a regression, it's an opportunity to partially revert a hack.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: