Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63662

pullRequest.reviewComment method is broken with ' line required and an integer greater than zero'

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • github-plugin
    • None

    Description

      Copied from https://github.com/jenkinsci/pipeline-github-plugin/issues/88

      Getting `org.eclipse.egit.github.core.client.RequestException: Validation Failed (422): line required and an integer greater than zero`
      The method documentation has a lineNumber parameter (https://github.com/jenkinsci/pipeline-github-plugin#adding-a-review-comment)

      while the code(https://github.com/jenkinsci/pipeline-github-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/github/PullRequestGroovyObject.java#L676-L679) has a position parameter and it needs both by GitHb Api Documentation (https://developer.github.com/v3/pulls/comments/#create-a-review-comment-for-a-pull-request).

      There's a fix (https://github.com/tomasbjerre/violation-comments-to-github-lib/pull/9/files#) to a similar problem

      Attachments

        Activity

          People

            lanwen Kirill Merkushev
            talbarda88 Tal Barda
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: