Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64327

[git-client] Don't fail builds if git server is unavailable

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Won't Fix
    • Component/s: git-client-plugin
    • Labels:
      None
    • Environment:
      jenkins/2.249.1 git-client/3.4.2
    • Similar Issues:

      Description

      Hi,

      I'm using git for the Source Code Management of my jenkins projects. During a git maintenance operation, I noticed that all builds would fail if the git server is unavailable.

      While this makes sense for some projects, I'd rather ran an outdated code than failing for some other projects.

      What do you think of making this behaviour configurable on a per project basis?

      Many thanks.

      Alex

        Attachments

          Activity

          Hide
          markewaite Mark Waite added a comment -

          Loss of the source code server that is backing a project is catastrophic in all but a very few cases. I am not willing to consider a plugin change that would make the loss of a source control server non-fatal. I would expect the number of failure modes to be very high and the value to the over 250 000 Jenkins installations to be relatively low.

          Show
          markewaite Mark Waite added a comment - Loss of the source code server that is backing a project is catastrophic in all but a very few cases. I am not willing to consider a plugin change that would make the loss of a source control server non-fatal. I would expect the number of failure modes to be very high and the value to the over 250 000 Jenkins installations to be relatively low.
          Hide
          acornet Alex Cornet added a comment -

          Hi Mark,

          Thanks for your reply.

          I get your concern and I'd like to clarify a few points:

          • we're not talking about irrecoverable loss here, more temporary unavailability. 
          • I totally get that this is not the desired behaviour for most projects, but making this behaviour opt-in wouldn't break any existing workflow. Are you concerned this feature would be incorrectly used in the field?

          Thanks,

          Alex

          Show
          acornet Alex Cornet added a comment - Hi Mark, Thanks for your reply. I get your concern and I'd like to clarify a few points: we're not talking about irrecoverable loss here, more temporary unavailability.  I totally get that this is not the desired behaviour for most projects, but making this behaviour opt-in wouldn't break any existing workflow. Are you concerned this feature would be incorrectly used in the field? Thanks, Alex
          Hide
          markewaite Mark Waite added a comment - - edited

          The git plugin is already a complicated collection of code that balances different requirements against one another so that they don't break compatibility for the 250 000 installations that depend on it. Adding a mode that causes a small set of users to expect that absence of a git server will be ignored is adding many places where inconsistences and oddities will be discovered and reported as issues. I would expect issue reports like, "Thing 1 does not ignore errors, but thing 2 does ignore them".

          I am unwilling to spend the time and energy to create that type of special case and then own its maintenance, bug reporting, and care. There is simply not enough benefit for the time I would be required to spend on it.

          You're certainly welcome to create a private fork of the git plugin and apply that type of change to the private fork. That then places the full maintenance responsibility on you so that you can decide what should be done when you detect issues.

          Show
          markewaite Mark Waite added a comment - - edited The git plugin is already a complicated collection of code that balances different requirements against one another so that they don't break compatibility for the 250 000 installations that depend on it. Adding a mode that causes a small set of users to expect that absence of a git server will be ignored is adding many places where inconsistences and oddities will be discovered and reported as issues. I would expect issue reports like, "Thing 1 does not ignore errors, but thing 2 does ignore them". I am unwilling to spend the time and energy to create that type of special case and then own its maintenance, bug reporting, and care. There is simply not enough benefit for the time I would be required to spend on it. You're certainly welcome to create a private fork of the git plugin and apply that type of change to the private fork. That then places the full maintenance responsibility on you so that you can decide what should be done when you detect issues.
          Hide
          acornet Alex Cornet added a comment -

          Hi Mark,

          This makes sense, thanks for taking the time to discuss this.

          Best,

          Alex

          Show
          acornet Alex Cornet added a comment - Hi Mark, This makes sense, thanks for taking the time to discuss this. Best, Alex

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            acornet Alex Cornet
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: