[JENKINS-64661] snippet generator for matrixauth JellyTagException - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Minor
Resolution: Fixed
Component/s: matrix-auth-plugin
Labels:
None
Environment:
Jenkins 2.263.2
matrix-auth-plugin 2.6.4

Similar Issues:

Show
Released As:
matrix-auth 2.6.5

Description

When attempting to load snippets for properties:

Caused by: org.apache.commons.jelly.JellyTagException: jar:file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-2.263.2.jar!/lib/form/nested.jelly:33:22: <d:invokeBody> org.apache.commons.jelly.JellyTagException: jar:file:/var/lib/jenkins/plugins/matrix-auth/WEB-INF/lib/matrix-auth.jar!/lib/matrixauth/blockWrapper.jelly:12:32: <d:invokeBody> Cannot get property 'class' on null object
	at org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:726)
	at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:281)
	at org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:100)
	at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
	at org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:100)
	at org.apache.commons.jelly.tags.core.CoreTagLibrary$2.run(CoreTagLibrary.java:105)
	at org.kohsuke.stapler.jelly.CallTagLibScript.run(CallTagLibScript.java:120)
	at org.kohsuke.stapler.jelly.groovy.JellyBuilder.doInvokeMethod(JellyBuilder.java:271)
	... 226 more

I note that the code in question has a todo noting that it should be removed once the tables-to-div PR has been merged:

https://github.com/jenkinsci/matrix-auth-plugin/blob/master/src/main/resources/lib/matrixauth/blockWrapper.jelly

Attachments

Issue Links

links to

PR 94

Activity

Ascending order - Click to sort in descending order

Daniel Beck added a comment - 2021-01-19 10:15

In my testing, this only happens on the (no longer linked) top-level snippet generator that is outside the context of any job. Could you confirm this is where this occurs, and the snippet generator works fine when accessed inside a job or folder?

Daniel Beck added a comment - 2021-01-19 10:15 In my testing, this only happens on the (no longer linked) top-level snippet generator that is outside the context of any job. Could you confirm this is where this occurs, and the snippet generator works fine when accessed inside a job or folder?

Daniel Beck added a comment - 2021-01-19 10:39

The reason this happens is https://github.com/jenkinsci/matrix-auth-plugin/blob/df6f6491f1d9ddab40fd4476852d8c9940c5762f/src/main/resources/hudson/security/AuthorizationMatrixProperty/config.groovy#L13 because there's no context to determine which inheritance options to show; they differ based on job vs. agent.

Daniel Beck added a comment - 2021-01-19 10:39 The reason this happens is https://github.com/jenkinsci/matrix-auth-plugin/blob/df6f6491f1d9ddab40fd4476852d8c9940c5762f/src/main/resources/hudson/security/AuthorizationMatrixProperty/config.groovy#L13 because there's no context to determine which inheritance options to show; they differ based on job vs. agent.

Bill Collins added a comment - 2021-01-19 11:12 - edited

Yes, that's correct - only breaks on top-level.

Bill Collins added a comment - 2021-01-19 11:12 - edited Yes, that's correct - only breaks on top-level.

Daniel Beck added a comment - 2021-01-19 11:36

While for this plugin in isolation, I don't think this is a notable problem, breaking part of the snippet generator completely shouldn't happen.

Daniel Beck added a comment - 2021-01-19 11:36 While for this plugin in isolation, I don't think this is a notable problem, breaking part of the snippet generator completely shouldn't happen.

Daniel Beck added a comment - 2021-01-19 11:59

mrginglymus If you can, please test the PR build.

Daniel Beck added a comment - 2021-01-19 11:59 mrginglymus If you can, please test the PR build.

Daniel Beck added a comment - 2021-01-20 23:09

PR is merged, I expect to release the fix tomorrow (Thursday)

Daniel Beck added a comment - 2021-01-20 23:09 PR is merged, I expect to release the fix tomorrow (Thursday)

Bill Collins added a comment - 2021-01-21 13:23

Thanks - updated and everything working now.

Bill Collins added a comment - 2021-01-21 13:23 Thanks - updated and everything working now.

People

Assignee:: Daniel Beck

Reporter:: Bill Collins

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2021-01-19 09:05

Updated:: 2021-01-21 13:23

Resolved:: 2021-01-20 23:09