Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67393

Can't display person icon on Assign Roles page after matrix auth 3.0 update

    XMLWordPrintable

Details

    • 484.v8a_a_e4b_d785fd

    Description

      After upgrading to 2.319.1, it can't display person icon on Assign Roles page

      Attachments

        Issue Links

          Activity

            i am affected as well.

            as a GUI level administrator
            i want my user management interface to assist me with meaningful user names and user ids
            so that my administration activities can be carried out correctly and efficiently in place.

            alexanderstohr Alexander Stohr added a comment - i am affected as well. as a GUI level administrator i want my user management interface to assist me with meaningful user names and user ids so that my administration activities can be carried out correctly and efficiently in place.
            mawinter69 Markus Winter added a comment -

            Looking at the code this is only a UI problem and should not have any impact on functionality of the plugin.

            The only thing rolestategy uses from matrix auth plugin is the function doCheckName from the descriptor of GlobalMatrixAuthorizationStrategy. This method is used to decide if the user/group exists and which icon to display.

            Locally I copied the relevant code from version 2.6.11 of matrix-auth to rolestrategy and the issue is gone and everything still compiles and works as before.

            The question is if we want to also have that separation between users and groups in rolestrategy. If yes that would be some bigger work I think and another question would be if we then want to keep the dependency to matrix auth plugin, probably some part of the code could be reused. After a first peek there are some code parts that are useful that are currently restricted with NoExternalUse

             

            mawinter69 Markus Winter added a comment - Looking at the code this is only a UI problem and should not have any impact on functionality of the plugin. The only thing rolestategy uses from matrix auth plugin is the function doCheckName from the descriptor of GlobalMatrixAuthorizationStrategy. This method is used to decide if the user/group exists and which icon to display. Locally I copied the relevant code from version 2.6.11 of matrix-auth to rolestrategy and the issue is gone and everything still compiles and works as before. The question is if we want to also have that separation between users and groups in rolestrategy. If yes that would be some bigger work I think and another question would be if we then want to keep the dependency to matrix auth plugin, probably some part of the code could be reused. After a first peek there are some code parts that are useful that are currently restricted with NoExternalUse  
            mawinter69 Markus Winter added a comment - - edited

            created PR #172 to decouple role-strategy from matrix-auth

            mawinter69 Markus Winter added a comment - - edited created PR #172 to decouple role-strategy from matrix-auth

            had a look. its not a one-line change, but it looks pretty promising in solving the most pressing aspects.

            to my understanding the one thing is "a bug" whilst the other things are "features" with surely some relation. establishing a sound foundation again instantly with fixing the first will allow to freely care (or skip) for the second.

            alexanderstohr Alexander Stohr added a comment - had a look. its not a one-line change, but it looks pretty promising in solving the most pressing aspects. to my understanding the one thing is "a bug" whilst the other things are "features" with surely some relation. establishing a sound foundation again instantly with fixing the first will allow to freely care (or skip) for the second.

            Thanks for PR #172: The role-strategy-3.2.1-rc486.1fa_5c858f488.hpi plugin (without its dependency on the matrix-auth plugin) seems to work fine in my various use cases.

            eraimbau Eric RAIMBAULT added a comment - Thanks for PR #172 : The role-strategy-3.2.1-rc486.1fa_5c858f488.hpi plugin (without its dependency on the matrix-auth plugin) seems to work fine in my various use cases.

            People

              oleg_nenashev Oleg Nenashev
              joelee Joe Lee
              Votes:
              38 Vote for this issue
              Watchers:
              51 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: