• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Since Jenkins 2.335 core SVG icons in the side panel are colored in blue (using a corresponding CSS class and the SVG attribute stroke='currectColor'). This coloring seems not to be applied to SVG icons that are not part of Jenkins core. It would be helpful if those icons would be colored in the same way.

      In this example, the Coverage Report is painted in black, but the Delete Pipeline is painted in blue.

          [JENKINS-67844] New icon theming not applied to non-core icons

          Ulli Hafner added a comment -

          I'm not sure if that can be done in the plugin SVG or if the CSS that wraps the SVG needs to be adapted in core.

          Ulli Hafner added a comment - I'm not sure if that can be done in the plugin SVG or if the CSS that wraps the SVG needs to be adapted in core.

          Jan Faracik added a comment -

          Hey, icon theming isn't possible for SVGs that are loaded via the `<img>` tag sadly. Just thinking off the top of my head I don't think it's possible for plugin developers to use icon theming for things like sidebar icons etc (yet) - this will be resolved when custom symbols are merged in.

          Jan Faracik added a comment - Hey, icon theming isn't possible for SVGs that are loaded via the `<img>` tag sadly. Just thinking off the top of my head I don't think it's possible for plugin developers to use icon theming for things like sidebar icons etc (yet) - this will be resolved when custom symbols are merged in.

          Ulli Hafner added a comment -

          I see. Why do we load SVGs with the <img> tag? Shouldn't Jenkins Core care about the correct handling of the file type?

          Ulli Hafner added a comment - I see. Why do we load SVGs with the <img> tag? Shouldn't Jenkins Core care about the correct handling of the file type?

          Jan Faracik added a comment -

          With custom symbols merged in now a few LTSs ago this should be resolvable now. 

          Jan Faracik added a comment - With custom symbols merged in now a few LTSs ago this should be resolvable now. 

          Ulli Hafner added a comment -

          Yes, this is fixed. We have two different icon sets available for plugin authors that support auto-coloring right now:

          Ulli Hafner added a comment - Yes, this is fixed. We have two different icon sets available for plugin authors that support auto-coloring right now: https://plugins.jenkins.io/ionicons-api/ https://plugins.jenkins.io/font-awesome-api

            janfaracik Jan Faracik
            drulli Ulli Hafner
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: