Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67849

Organization folder not displayed when Jenkins is launched with a prefix (regression in 2.335)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • 2.344

      I've upgraded to 2.335 from 2.334, and the folder icons no longer display correctly when a JENKINS_PREFIX is included in the config, such as:

      [Service]
      Environment="JENKINS_PREFIX=/jenkins"
      

      The prefix is added to the absolute URLs:


          [JENKINS-67849] Organization folder not displayed when Jenkins is launched with a prefix (regression in 2.335)

          The issue still exists in 2.338 (run as war deployment to a tomcat instance)

          It renders:

          <img src="/jenkinshttps://myjenkinsinstance.de/jenkins/custom-avatar-cache/1ec36e9f1a1fb54db76fdc2a5a60b6c5.png?size=48x48" alt="Bitbucket Team/Project" width="48" tooltip="Bitbucket Team/Project" height="48" title="Bitbucket Team/Project">
          

          seemingly conflating context path with the full url

          Christof Schoell added a comment - The issue still exists in 2.338 (run as war deployment to a tomcat instance) It renders: <img src= "/jenkinshttps: //myjenkinsinstance.de/jenkins/custom-avatar-cache/1ec36e9f1a1fb54db76fdc2a5a60b6c5.png?size=48x48" alt= "Bitbucket Team/Project" width= "48" tooltip= "Bitbucket Team/Project" height= "48" title= "Bitbucket Team/Project" > seemingly conflating context path with the full url

          Andrew Miller added a comment -

          Still seeing the issue in 2.340. Issue seems to come when the supplied URL is a fullpath vs a relative path? The default icons for disabled projects and the SVG folder icon are displaying just fine in my case, but the GitHub project/Bitbucket server icons are receiving full paths and getting the prefix prepended.

          Andrew Miller added a comment - Still seeing the issue in 2.340. Issue seems to come when the supplied URL is a fullpath vs a relative path? The default icons for disabled projects and the SVG folder icon are displaying just fine in my case, but the GitHub project/Bitbucket server icons are receiving full paths and getting the prefix prepended.

          Basil Crow added a comment -

          As described in the comments in JENKINS-67823, this issue persists in 2.342 GitHub and Bitbucket organisations with a path prefix.

          Basil Crow added a comment - As described in the comments in JENKINS-67823 , this issue persists in 2.342 GitHub and Bitbucket organisations with a path prefix.

          Basil Crow added a comment -

          I can reproduce the problem by installing 2.333 and all suggested plugins, including GitHub Branch Source. I then started Jenkins with --prefix=/jenkins and created a GitHub Organization Folder for a user with a custom icon. I verified that the icon displayed correctly. Then I upgraded to HEAD (commit b37ea91bf3) and get the results shown in this screenshot. Bisection shows that the bug was introduced in jenkinsci/jenkins#6186.

          Basil Crow added a comment - I can reproduce the problem by installing 2.333 and all suggested plugins, including GitHub Branch Source. I then started Jenkins with --prefix=/jenkins and created a GitHub Organization Folder for a user with a custom icon. I verified that the icon displayed correctly. Then I upgraded to HEAD (commit b37ea91bf3) and get the results shown in this screenshot . Bisection shows that the bug was introduced in jenkinsci/jenkins#6186 .

          Han Geerligs added a comment - - edited

          please note icon is missing as well for Gitlab organisations.

          Jenkins is in my case not launched with prefix.

          Han Geerligs added a comment - - edited please note icon is missing as well for Gitlab organisations. Jenkins is in my case not launched with prefix.

          I think some disorder in reopening an reclosing tasks...
          The closed task(JENKINS-67823) problem should continue here, because comment: https://issues.jenkins.io/browse/JENKINS-67823?focusedCommentId=424258&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-424258

          For the existing bug please see JENKINS-67823 history or this comment for example: https://issues.jenkins.io/browse/JENKINS-67823?focusedCommentId=423876&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-423876

          The original icon uri problem still present with or without concatenated prefix problem:

          István Gulyás added a comment - I think some disorder in reopening an reclosing tasks... The closed task( JENKINS-67823 ) problem should continue here, because comment: https://issues.jenkins.io/browse/JENKINS-67823?focusedCommentId=424258&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-424258 For the existing bug please see JENKINS-67823 history or this comment for example: https://issues.jenkins.io/browse/JENKINS-67823?focusedCommentId=423876&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-423876 The original icon uri problem still present with or without concatenated prefix problem:

          Basil Crow added a comment -

          Jenkins is in my case not launched with prefix.

          han_geerligs Please do not comment in this ticket if your problem does not match the title of the ticket, which reads:

          Organization folder not displayed when Jenkins is launched with a prefix (regression in 2.335)

          If you are not using a prefix, please open a new ticket with steps to reproduce the issue from scratch and the labels "ux" and "regression.

          Basil Crow added a comment - Jenkins is in my case not launched with prefix. han_geerligs Please do not comment in this ticket if your problem does not match the title of the ticket, which reads: Organization folder not displayed when Jenkins is launched with a prefix (regression in 2.335) If you are not using a prefix, please open a new ticket with steps to reproduce the issue from scratch and the labels "ux" and "regression.

          Basil Crow added a comment -

          Released in 2.344. ben_gineer cschoell Could you please verify that the issue has been resolved? Thanks!

          Basil Crow added a comment - Released in 2.344. ben_gineer cschoell Could you please verify that the issue has been resolved? Thanks!

          Ben Middleton added a comment -

          All fixed in 2.344. Many thanks.

          Ben Middleton added a comment - All fixed in 2.344. Many thanks.

          I can confirm that it works fine now, thanks!

          Christof Schoell added a comment - I can confirm that it works fine now, thanks!

            timja Tim Jacomb
            ben_gineer Ben Middleton
            Votes:
            6 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: