• 2.0.0

      Icons in the build pipeline view seems to be broken after upgrade of Jenkins

      Previous Jenkins Version: 2.315

      Current Jenkins Version:  2.337

       

       

          [JENKINS-68022] Icon images broken on build pipeline view

          The last release of the plugin was 4years ago, according to the plugin site. There is even an XSS warning on the plugin from the security team.

          I believe that the problem was introduced by https://github.com/jenkinsci/jenkins/pull/5778 when we removed the PNG files from Jenkins. The icons are directly called from https://github.com/jenkinsci/build-pipeline-plugin/blob/d227e5e30fa6a62c56c5cbbc3d1d460c88880009/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly#L60-L110.

          Adrien Lecharpentier added a comment - The last release of the plugin was 4years ago, according to the plugin site. There is even an XSS warning on the plugin from the security team. I believe that the problem was introduced by https://github.com/jenkinsci/jenkins/pull/5778 when we removed the PNG files from Jenkins. The icons are directly called from https://github.com/jenkinsci/build-pipeline-plugin/blob/d227e5e30fa6a62c56c5cbbc3d1d460c88880009/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly#L60-L110 .

          Basil Crow added a comment - - edited

          Nevertheless, the plugin is not deprecated, so it is still officially supported by the Jenkins project. If we wish to drop support for this plugin, the author of JENKINS-68249 needs to submit a PR to the Update Center marking this plugin as deprecated. In the absence of such a PR, the plugin remains supported, and the broken icon remains a core regression (and will be tracked as such).

          Basil Crow added a comment - - edited Nevertheless, the plugin is not deprecated, so it is still officially supported by the Jenkins project. If we wish to drop support for this plugin, the author of JENKINS-68249 needs to submit a PR to the Update Center marking this plugin as deprecated. In the absence of such a PR, the plugin remains supported, and the broken icon remains a core regression (and will be tracked as such).

          I'm looking at a way to update the plugin a bit so the fix for this is simplified. I'm not sure we want another release of the plugin with the XSS so that would need to be worked on as well.

          Adrien Lecharpentier added a comment - I'm looking at a way to update the plugin a bit so the fix for this is simplified. I'm not sure we want another release of the plugin with the XSS so that would need to be worked on as well.

          Basil Crow added a comment -

          I think as long as a tested PR has been filed against that plugin, we have done our due diligence. Another option is to officially mark the plugin as deprecated in the Update Center. I do not feel strongly either way.

          Basil Crow added a comment - I think as long as a tested PR has been filed against that plugin, we have done our due diligence. Another option is to officially mark the plugin as deprecated in the Update Center. I do not feel strongly either way.

          I created https://github.com/jenkinsci/build-pipeline-plugin/pull/124 so fix this problem.

          I included a preview of the fix in the PR.

          Adrien Lecharpentier added a comment - I created https://github.com/jenkinsci/build-pipeline-plugin/pull/124 so fix this problem. I included a preview of the fix in the PR.

          Hello alecharp sorry to ping you about this, but the PR seems to be stuck waiting for a build error to be fixed:

          [INFO] --- access-modifier-checker:1.27:enforce (default-enforce) @ build-pipeline-plugin --- [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:310 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:314 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger$DescriptorImpl:318 hudson/tasks/Messages must not be used [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 14.179 s [INFO] Finished at: 2022-08-02T15:29:54-06:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.kohsuke:access-modifier-checker:1.27:enforce (default-enforce) on project build-pipeline-plugin: Access modifier checks failed. See the details above -> [Help 1] 
          

          https://github.com/jenkinsci/build-pipeline-plugin/pull/124

          Would someone have time to please address it? Thank you in advance for your help !

          Goffredo Marocchi added a comment - Hello alecharp sorry to ping you about this, but the PR seems to be stuck waiting for a build error to be fixed: [INFO] --- access-modifier-checker:1.27:enforce (default-enforce) @ build-pipeline-plugin --- [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger $DescriptorImpl :310 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger $DescriptorImpl :314 hudson/tasks/Messages must not be used [ERROR] au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTrigger $DescriptorImpl :318 hudson/tasks/Messages must not be used [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time : 14.179 s [INFO] Finished at: 2022-08-02T15:29:54-06:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.kohsuke:access-modifier-checker:1.27:enforce (default-enforce) on project build-pipeline-plugin: Access modifier checks failed. See the details above -> [Help 1] https://github.com/jenkinsci/build-pipeline-plugin/pull/124 Would someone have time to please address it? Thank you in advance for your help !

            alecharp Adrien Lecharpentier
            s_bhatia S Bhatia
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: