Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68205

Strange line breaks on Firefox 91.8.0esr when Build History uses wbr within display: inline-flex (regression in 2.321)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • Jenkins 2.332.1
      Mozilla Firefox 91.8.0esr
    • 2.349

    Description

      The build history page has this hyperlink in a table cell (redacted by changing letters and digits to x and 1):

      <a class="jenkins-table__link model-link inside" href="/jenkins/job/XXX/job/xxxxxxxxxxxx-xxxxxxxx-xxxxxxxxxx/job/xxxxxxx%252FXXXXX-111_xxxxxxxxxxxxxxxxx/">Xx Xxxxxx » Xxxxxxxxxxxx xxxxxxxx xxxxxxxxxx » xxxxxxx<wbr>/XXXXX<wbr>-111<wbr>_xxxxxxxxxxxxxxxxx</a>
      

      and this CSS rule applies to it:

      .jenkins-table__link, .jenkins-table .sortheader {
          display: inline-flex;
      }
      

      Microsoft Edge 100.0.1185.29 renders it nicely:

      Mozilla Firefox 91.8.0esr however breaks the "Xx Xxxxxx » Xxxxxxxxxxxx xxxxxxxx xxxxxxxxxx » xxxxxxx" part (before the first <wbr> tag) to two lines, and then renders the rest "/XXXXX-111_xxxxxxxxxxxxxxxxx" at the right side of that, even centering it vertically:

      I don't know whether that is a Firefox bug or what, but perhaps the compatibility can be improved somehow.

      If I disable display: inline-flex; in the CSS rule, then the line breaks look a lot nicer in Firefox 91.8.0esr:

      Alternatively, if I keep the original CSS rule but replace each <wbr> with &#x200B;, then Firefox 91.8.0esr renders like this:

      Attachments

        1. after.png
          30 kB
          Basil Crow
        2. before.png
          35 kB
          Basil Crow
        3. edge-100.0.1185.29.png
          18 kB
          Kalle Niemitalo
        4. firefox-91.8.0esr.png
          16 kB
          Kalle Niemitalo
        5. firefox-91.8.0esr-without-inline-flex.png
          14 kB
          Kalle Niemitalo
        6. firefox-91.8.0esr-ZWSP.png
          14 kB
          Kalle Niemitalo

        Issue Links

          Activity

            The <wbr> seems to be inserted by hudson.Functions.breakableString, which was last modified on 2014-04-30. It is called from jenkins.widgets.BuildListTable.calculate, and this call was last modified on 2013-12-06. The resulting parentFullDisplayName is used in buildListTable.jelly, and the jenkins-table__link CSS class was added there in jenkinsci/jenkins#5851.

            kon Kalle Niemitalo added a comment - The <wbr> seems to be inserted by hudson.Functions.breakableString, which was last modified on 2014-04-30. It is called from jenkins.widgets.BuildListTable.calculate, and this call was last modified on 2013-12-06. The resulting parentFullDisplayName is used in buildListTable.jelly, and the jenkins-table__link CSS class was added there in jenkinsci/jenkins#5851 .

            I am not currently able to test custom versions of the Jenkins core.

            kon Kalle Niemitalo added a comment - I am not currently able to test custom versions of the Jenkins core.
            basil Basil Crow added a comment -

            Thanks kon. If I'm not asking too much, could I trouble you to confirm that the issue is present in 2.321 and absent in 2.320? If this is too much trouble, I will try to reproduce myself later next week.

            basil Basil Crow added a comment - Thanks kon . If I'm not asking too much, could I trouble you to confirm that the issue is present in 2.321 and absent in 2.320? If this is too much trouble, I will try to reproduce myself later next week.
            basil Basil Crow added a comment -

            I can reproduce the problem by creating a job with the name you have given in the folder structure you have given, then creating a list view containing only that job and then visiting the list view. I have attached before and after screenshots. I can confirm the bug was introduced in JENKINS-68229.

            basil Basil Crow added a comment - I can reproduce the problem by creating a job with the name you have given in the folder structure you have given, then creating a list view containing only that job and then visiting the list view. I have attached before and after screenshots. I can confirm the bug was introduced in JENKINS-68229 .
            basil Basil Crow added a comment -

            BTW I am running Firefox 99.0 on Ubuntu 20.04.4 LTS x86_64.

            basil Basil Crow added a comment - BTW I am running Firefox 99.0 on Ubuntu 20.04.4 LTS x86_64.

            People

              felix_416 Feng-Yi Xue
              kon Kalle Niemitalo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: