Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68288

Object context in BuildCondition.meetsCondition is sometimes a Stage instance, which is not recognized by BuildCondition.getCombinedResult

    XMLWordPrintable

Details

    Description

      If BuildCondition.getCombinedResult is called in relation to a stage, then its Object context parameter can be either a Stage instance or the name of the stage as a String. BuildCondition.getCombinedResult however recognizes only the String type and not the Stage type. If a Stage instance is passed in, then BuildCondition.getCombinedResult does not search for a WarningAction in the stage, and might compute an incorrect Result.

      I found this while looking at the source code for the sake of JENKINS-68281. I have not reproduced the problem in practice.

      This inconsistency came from PR #330 for JENKINS-57826.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kon Kalle Niemitalo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: