Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68291

Plugin manager filter is not reset on clicking "X" button in Blink and WebKit browsers (regression in 2.325)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Jenkins 2.343
      Chrome 100
    • 2.345

      Open plugin manager, installed plugins.

      Type a filter text like "file" into the filter field -> The installed plugins are filtered.

      Click the "X" button on the right of the filter box.

      Bug: The plugin list remains filtered. The filter field text is empty, but the filter remains active until some key is pressed inside the filter field. Screenshot shows the situation, the filter "file" is still applied and only 4 plugins are shown, even though the filter field is empty: 

          [JENKINS-68291] Plugin manager filter is not reset on clicking "X" button in Blink and WebKit browsers (regression in 2.325)

          For reference, the issue does only apply to the "Installed" tab. The correct behavior can be reproduced by applying the steps to the "Available" tab.

          Alexander Brandes added a comment - For reference, the issue does only apply to the "Installed" tab. The correct behavior can be reproduced by applying the steps to the "Available" tab.

          Mark Waite added a comment - - edited

          notmyfault, I think that this is not a regression. On Jenkins 2.332..2 I see the same behavior:

          Narrow the Jenkins 2.332.2 search by entering 'mercurial' in the filter field

          Clear the Jenkins 2.332.2 search by clicking the "x" in the filter field

          After clearing the search, the list is still only showing "Mercurial", even though the list is no longer filtered.

          I agree that it is a bug and it is surprising, but I don't think that it is a regression, at least not a recent regression.

          I confirmed that the same behavior is seen in the 2.344 pre-release build that I created from the current master branch.

          Mark Waite added a comment - - edited notmyfault , I think that this is not a regression. On Jenkins 2.332..2 I see the same behavior: Narrow the Jenkins 2.332.2 search by entering 'mercurial' in the filter field Clear the Jenkins 2.332.2 search by clicking the "x" in the filter field After clearing the search, the list is still only showing "Mercurial", even though the list is no longer filtered. I agree that it is a bug and it is surprising, but I don't think that it is a regression, at least not a recent regression. I confirmed that the same behavior is seen in the 2.344 pre-release build that I created from the current master branch.

          Basil Crow added a comment -

          What is this "X" button on the right of the filter box that you all are talking about? I went to http://127.0.0.1:8080/pluginManager/installed on both 2.324 and 2.334 and typed in "Mercurial" like Mark did. The list got filtered, but I don't see any X button to the right of the filter box to click on. I'm running Firefox 99.0 (Ubuntu 64-bit).

          Basil Crow added a comment - What is this "X" button on the right of the filter box that you all are talking about? I went to http://127.0.0.1:8080/pluginManager/installed on both 2.324 and 2.334 and typed in "Mercurial" like Mark did. The list got filtered, but I don't see any X button to the right of the filter box to click on. I'm running Firefox 99.0 (Ubuntu 64-bit).

          The "x" to clear the text box is only shown when you're focusing on the text box. If you click somewhere else it vanishes:

           https://issues.jenkins.io/secure/attachment/57804/5c12effbbd27c79c17cf0e420b270b30.mp4

          Alexander Brandes added a comment - The "x" to clear the text box is only shown when you're focusing on the text box. If you click somewhere else it vanishes:   https://issues.jenkins.io/secure/attachment/57804/5c12effbbd27c79c17cf0e420b270b30.mp4

          Basil Crow added a comment - - edited

          I don't see that X even when I am focused on the textbox on any version of Jenkins. I am running Firefox 99.0 on Ubuntu 20.04.

          Basil Crow added a comment - - edited I don't see that X even when I am focused on the textbox on any version of Jenkins. I am running Firefox 99.0 on Ubuntu 20.04.

          Alexander Brandes added a comment - - edited

          Firefox may be the reason why, it's displayed fine on Chrome 100.0 for me when.

          However, when using Firefox, I can't see it either.

          Alexander Brandes added a comment - - edited Firefox may be the reason why, it's displayed fine on Chrome 100.0 for me when. However, when using Firefox, I can't see it either.

          Basil Crow added a comment -

          I tried reproducing on my macOS laptop. I could not reproduce on Firefox there either, but I can reproduce on Safari 15.4 (17613.1.17.1.13). On Safari 15.4 I can see the X starting with JENKINS-68285 and jenkinsci/jenkins#5916, but not before. With that same commit, clicking on the X does not clear the filter as expected. So this functionality was broken at time of delivery. From one perspective this is not a regression, since there was no X before that could have been clicked on. But I am still labeling this with the regression label, since from another perspective it could be argued that prior to JENKINS-68285 there was no way for a user to reach this bad state, but now there is.

          Basil Crow added a comment - I tried reproducing on my macOS laptop. I could not reproduce on Firefox there either, but I can reproduce on Safari 15.4 (17613.1.17.1.13). On Safari 15.4 I can see the X starting with JENKINS-68285 and jenkinsci/jenkins#5916 , but not before. With that same commit, clicking on the X does not clear the filter as expected. So this functionality was broken at time of delivery. From one perspective this is not a regression, since there was no X before that could have been clicked on. But I am still labeling this with the regression label, since from another perspective it could be argued that prior to JENKINS-68285 there was no way for a user to reach this bad state, but now there is.

          Jan Faracik added a comment -

          Opened a fix for that here https://github.com/jenkinsci/jenkins/pull/6500, thanks for raising  

          Jan Faracik added a comment - Opened a fix for that here https://github.com/jenkinsci/jenkins/pull/6500,  thanks for raising  

            janfaracik Jan Faracik
            bananeweizen Michael Keppler
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: