-
Improvement
-
Resolution: Fixed
-
Minor
-
None
It would be nice to make build time trend green for successful builds.
Currently it still shows succeeded build in blue although greenballs are active.
This can be confusing for newbies / occasional users, e.g. if you have cancelled and successful builds only, the graph is grey and blue and you first cannot figure out why.
[JENKINS-6838] make build time trend green for successful builds
asgeirn
added a comment - I've done a trial build using Koshuke's suggested solution. What do you think?
asgeirn
added a comment - I've done a trial build using Koshuke's suggested solution. What do you think? Code changed in hudson
User: : asgeirn
Path:
trunk/hudson/plugins/greenballs/pom.xml
trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/GreenBallFilter.java
trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/PluginImpl.java
trunk/hudson/plugins/greenballs/src/test/java/hudson/plugins/greenballs/GreenBallIntegrationTest.java
http://jenkins-ci.org/commit/32699
Log:
Fixes for JENKINS-6457 and JENKINS-6838.
Harry G.
added a comment - Tried the attached 1.7-SNAPSHOT. Works fine for me!
Good job, resolved fast, thanks!
Harry G.
added a comment - Tried the attached 1.7-SNAPSHOT. Works fine for me!
Good job, resolved fast, thanks! Harry G.
added a comment - will this fix be officially released in near future? A colleague wants to use it and I rather would not like to give him the snapshot build...
Harry G.
added a comment - will this fix be officially released in near future? A colleague wants to use it and I rather would not like to give him the snapshot build... asgeirn
added a comment - Ooops, my bad. I'll release the changes this evening. Thanks for reminding me 
asgeirn
added a comment - Ooops, my bad. I'll release the changes this evening. Thanks for reminding me asgeirn
added a comment - Released in version 1.7. 
mdp
added a comment - This also changes blue to green for low severity warnings in the various static analysis trends graphs. I suppose this may be considered either a good thing or a little bit confusing - low severity warnings are still warnings, so green does not mean good here.
mdp
added a comment - This also changes blue to green for low severity warnings in the various static analysis trends graphs. I suppose this may be considered either a good thing or a little bit confusing - low severity warnings are still warnings, so green does not mean good here. Harry G.
added a comment - For me it's OK. As in Japan blue means good, green should be equivalent everywhere and nothing is made worse. E.g. low severity warnings before were blue=OK in Japan, now green=OK in rest of the world...
Harry G.
added a comment - For me it's OK. As in Japan blue means good, green should be equivalent everywhere and nothing is made worse. E.g. low severity warnings before were blue=OK in Japan, now green=OK in rest of the world... 
starwarsfan
added a comment - @harrygg:
Whomsoever I show Hudson, the first question is, why a successful job is blue and not green. No I know why. Thx for the note, now I know why "blue" is the default.
starwarsfan
added a comment - @harrygg:
Whomsoever I show Hudson, the first question is, why a successful job is blue and not green. No I know why. Thx for the note, now I know why "blue" is the default. 
One can do this by using reflection to overwrite the ColorPalette.BLUE constant.