Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6838

make build time trend green for successful builds

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • greenballs-plugin
    • None

      It would be nice to make build time trend green for successful builds.
      Currently it still shows succeeded build in blue although greenballs are active.
      This can be confusing for newbies / occasional users, e.g. if you have cancelled and successful builds only, the graph is grey and blue and you first cannot figure out why.

          [JENKINS-6838] make build time trend green for successful builds

          Harry G. created issue -
          Harry G. made changes -
          Description Original: It would be nice to make build time trend green for successful builds.
          Currently it still shows succeeded build in blue althoug greenballs are active.
          This can be confusing for newbies / occasional users, e.g. if you have cancelled and successful builds they are grey and blue and you first cannot figure out why.
          New: It would be nice to make build time trend green for successful builds.
          Currently it still shows succeeded build in blue although greenballs are active.
          This can be confusing for newbies / occasional users, e.g. if you have cancelled and successful builds only, the graph is grey and blue and you first cannot figure out why.

          One can do this by using reflection to overwrite the ColorPalette.BLUE constant.

          Kohsuke Kawaguchi added a comment - One can do this by using reflection to overwrite the ColorPalette.BLUE constant.

          asgeirn added a comment -

          I've done a trial build using Koshuke's suggested solution. What do you think?

          asgeirn added a comment - I've done a trial build using Koshuke's suggested solution. What do you think?
          asgeirn made changes -
          Attachment New: greenballs.hpi [ 19567 ]

          Code changed in hudson
          User: : asgeirn
          Path:
          trunk/hudson/plugins/greenballs/pom.xml
          trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/GreenBallFilter.java
          trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/PluginImpl.java
          trunk/hudson/plugins/greenballs/src/test/java/hudson/plugins/greenballs/GreenBallIntegrationTest.java
          http://jenkins-ci.org/commit/32699
          Log:
          Fixes for JENKINS-6457 and JENKINS-6838.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : asgeirn Path: trunk/hudson/plugins/greenballs/pom.xml trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/GreenBallFilter.java trunk/hudson/plugins/greenballs/src/main/java/hudson/plugins/greenballs/PluginImpl.java trunk/hudson/plugins/greenballs/src/test/java/hudson/plugins/greenballs/GreenBallIntegrationTest.java http://jenkins-ci.org/commit/32699 Log: Fixes for JENKINS-6457 and JENKINS-6838 .

          Harry G. added a comment -

          Tried the attached 1.7-SNAPSHOT. Works fine for me!
          Good job, resolved fast, thanks!

          Harry G. added a comment - Tried the attached 1.7-SNAPSHOT. Works fine for me! Good job, resolved fast, thanks!
          Alan Harder made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Harry G. added a comment -

          will this fix be officially released in near future? A colleague wants to use it and I rather would not like to give him the snapshot build...

          Harry G. added a comment - will this fix be officially released in near future? A colleague wants to use it and I rather would not like to give him the snapshot build...

          asgeirn added a comment -

          Ooops, my bad. I'll release the changes this evening. Thanks for reminding me

          asgeirn added a comment - Ooops, my bad. I'll release the changes this evening. Thanks for reminding me

            asgeirn asgeirn
            harrygg Harry G.
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: