Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68674

Icon for folder credentials store is gone from credentials plugin

    XMLWordPrintable

Details

    Attachments

      Issue Links

        Activity

          Whatever was calling the `getIconFileName()` function should be updated to call `getIconClassName()` which will use the correct svg for the icon.

          kerogers Kenneth Rogers added a comment - Whatever was calling the `getIconFileName()` function should be updated to call `getIconClassName()` which will use the correct svg for the icon.
          jglick Jesse Glick added a comment -

          timja notmyfault anyone volunteer to fix this? Sounds like it suffices to switch to folder-store.svg (though perhaps that should be moved into cloudbees-folder from credentials, assuming it is used for only this purpose).

          jglick Jesse Glick added a comment - timja notmyfault anyone volunteer to fix this? Sounds like it suffices to switch to folder-store.svg (though perhaps that should be moved into cloudbees-folder from credentials , assuming it is used for only this purpose).
          notmyfault Alexander Brandes added a comment - - edited

          Looks like it's caused by https://github.com/jenkinsci/cloudbees-folder-plugin/blob/master/src/main/java/com/cloudbees/hudson/plugins/folder/properties/FolderCredentialsProvider.java#L582,
          when I got a rid of the PNGs and moved the SVGs, the reference got lost.

          To note: Once https://github.com/jenkinsci/cloudbees-folder-plugin/pull/237 is pulled in, we can use a symbol here over a tango icon.

          notmyfault Alexander Brandes added a comment - - edited Looks like it's caused by https://github.com/jenkinsci/cloudbees-folder-plugin/blob/master/src/main/java/com/cloudbees/hudson/plugins/folder/properties/FolderCredentialsProvider.java#L582 , when I got a rid of the PNGs and moved the SVGs, the reference got lost. To note: Once https://github.com/jenkinsci/cloudbees-folder-plugin/pull/237 is pulled in, we can use a symbol here over a tango icon.
          twasyl Thierry Wasylczenko added a comment - Hello, I submitted a PR for this one: https://github.com/jenkinsci/cloudbees-folder-plugin/pull/239

          People

            twasyl Thierry Wasylczenko
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: