Details
-
Bug
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
Description
https://github.com/jenkinsci/credentials-plugin/pull/230 removed folder-store.png which is referenced by https://github.com/jenkinsci/cloudbees-folder-plugin/blob/master/src/main/java/com/cloudbees/hudson/plugins/folder/properties/FolderCredentialsProvider.java resulting in a missing icon in bread crumb context menus.
Attachments
Issue Links
- relates to
-
-
- Open
-
Activity
timja notmyfault anyone volunteer to fix this? Sounds like it suffices to switch to folder-store.svg (though perhaps that should be moved into cloudbees-folder from credentials, assuming it is used for only this purpose).
Looks like it's caused by https://github.com/jenkinsci/cloudbees-folder-plugin/blob/master/src/main/java/com/cloudbees/hudson/plugins/folder/properties/FolderCredentialsProvider.java#L582,
when I got a rid of the PNGs and moved the SVGs, the reference got lost.
To note: Once https://github.com/jenkinsci/cloudbees-folder-plugin/pull/237 is pulled in, we can use a symbol here over a tango icon.
Alexander Brandes
added a comment - - edited Looks like it's caused by https://github.com/jenkinsci/cloudbees-folder-plugin/blob/master/src/main/java/com/cloudbees/hudson/plugins/folder/properties/FolderCredentialsProvider.java#L582 ,
when I got a rid of the PNGs and moved the SVGs, the reference got lost.
To note: Once https://github.com/jenkinsci/cloudbees-folder-plugin/pull/237 is pulled in, we can use a symbol here over a tango icon. Hello, I submitted a PR for this one: https://github.com/jenkinsci/cloudbees-folder-plugin/pull/239
Whatever was calling the `getIconFileName()` function should be updated to call `getIconClassName()` which will use the correct svg for the icon.