Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68904

Frontend build is not lint-clean

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Running mvn clean verify one sees a significant number of linter violations in the yarn lint phase. https://github.com/jenkinsci/jenkins/pull/6720 addresses some of the violations, but many still remain. Fixing these violations is a prerequisite for ensuring that the introduction of a new frontend lint violation fails the build in JENKINS-68903.

          [JENKINS-68904] Frontend build is not lint-clean

          Basil Crow added a comment -

          https://github.com/jenkinsci/jenkins/pull/6720 by notmyfault fixes 112 warnings! 🥳 That puts a big dent in this task, which is excellent.

          Basil Crow added a comment - https://github.com/jenkinsci/jenkins/pull/6720 by notmyfault fixes 112 warnings! 🥳 That puts a big dent in this task, which is excellent.

          Alexander Brandes added a comment - - edited

          To add up some more information, there are two kinds of lint failures that need to be addressed. Stylelint for CSS and ESLint for JS. To list open issues in a quicker way than using maven verify step, we can invoke the npm binary directly via npx, like "npx eslint ." or "npx stylelint src/main/less" to run them separately from the war directory.

          Alexander Brandes added a comment - - edited To add up some more information, there are two kinds of lint failures that need to be addressed. Stylelint for CSS and ESLint for JS. To list open issues in a quicker way than using maven verify step, we can invoke the npm binary directly via npx, like " npx eslint . " or " npx stylelint src/main/less " to run them separately from the war directory.

          Alexander Brandes added a comment -

          All linked PRs have been merged and the build is lint clean.

          Alexander Brandes added a comment - All linked PRs have been merged and the build is lint clean.

            notmyfault Alexander Brandes
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: