• 2.358

      Sort of a regression:

      The form loading screen was recently updated to be mostly white, hiding all loading UI completely.

      However, while the loading screen is shown, it's possible to scroll, and the top of the UI (top bar and a bit below it) will still show a slice of the config UI.

          [JENKINS-68934] Loading screen does not hide all UI

          Daniel Beck added a comment -

          Attached screenshot is from the new config form PR build but I expect it's the same in general.

          Daniel Beck added a comment - Attached screenshot is from the new config form PR build but I expect it's the same in general.

          Jan Faracik added a comment - - edited

          Fixed in PR #6687

          Thanks for raising  

          Jan Faracik added a comment - - edited Fixed in PR  #6687 Thanks for raising  

          Daniel Beck added a comment -

          This is not actually resolved as of 2.359. If I break some JS, the loading screen keeps showing and I can scroll down and see parts of the page scroll by near the top.

          Daniel Beck added a comment - This is not actually resolved as of 2.359. If I break some JS, the loading screen keeps showing and I can scroll down and see parts of the page scroll by near the top.

          Tim Jacomb added a comment -

          danielbeck Can you please provide steps to reproduce? I haven't been able to

          Tim Jacomb added a comment - danielbeck Can you please provide steps to reproduce? I haven't been able to

          Daniel Beck added a comment - - edited

          Works for me by commenting out https://github.com/jenkinsci/jenkins/blob/a2ce953fcb726184584a23554528eae8de7b69e7/war/src/main/webapp/scripts/hudson-behavior.js#L1736.

          Looks like in the more than two years since I reported this wasn't fixed, the loading UI was changed further: now the entire page content is blurred. It can still be scrolled though, and scrolling reveals UI elements moving. Still not ideal, but much better. Attached a recording made from today's master.

          Daniel Beck added a comment - - edited Works for me by commenting out https://github.com/jenkinsci/jenkins/blob/a2ce953fcb726184584a23554528eae8de7b69e7/war/src/main/webapp/scripts/hudson-behavior.js#L1736 . Looks like in the more than two years since I reported this wasn't fixed, the loading UI was changed further: now the entire page content is blurred. It can still be scrolled though, and scrolling reveals UI elements moving. Still not ideal, but much better. Attached a recording made from today's master .

          Daniel Beck added a comment -

          I bisected the improvement to the undocumented change https://github.com/jenkinsci/jenkins/pull/7012.

          Daniel Beck added a comment - I bisected the improvement to the undocumented change https://github.com/jenkinsci/jenkins/pull/7012 .

          Tim Jacomb added a comment -

          Can you explain how commenting out required code for the functionality results in a bug please?

          The visibility:collapse is removed by doing that:
          https://github.com/jenkinsci/jenkins/blob/a2ce953fcb726184584a23554528eae8de7b69e7/src/main/scss/components/_spinner.scss#L75C5-L75C15

          Which makes it so space is still taken up but its hidden

          Tim Jacomb added a comment - Can you explain how commenting out required code for the functionality results in a bug please? The visibility:collapse is removed by doing that: https://github.com/jenkinsci/jenkins/blob/a2ce953fcb726184584a23554528eae8de7b69e7/src/main/scss/components/_spinner.scss#L75C5-L75C15 Which makes it so space is still taken up but its hidden

          Daniel Beck added a comment -

          Can you explain how commenting out required code for the functionality results in a bug please?

          Because it's far easier to do that than to figure out how to set up an instance that is slow to respond with lots of content on a config page load.

          Can you explain how commenting this out to artificially increase how long the "Loading" screen is shown invalidates the report?

          Daniel Beck added a comment - Can you explain how commenting out required code for the functionality results in a bug please? Because it's far easier to do that than to figure out how to set up an instance that is slow to respond with lots of content on a config page load. Can you explain how commenting this out to artificially increase how long the "Loading" screen is shown invalidates the report?

            janfaracik Jan Faracik
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: