Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69153

Extended email notification edit page not working

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Jenkins version 2.358 and higher.
    • 1.5

      Email templates can't be editted or added due to not working add/eddit webpage and all subpages. All previously added templates seems to work correctly when they're set in jobs.

      Plugin in 1.4 (latest) version.

      http://localhost:8080/emailexttemplates/

       

          [JENKINS-69153] Extended email notification edit page not working

          Mark Waite added a comment - - edited

          I also see the problem in Jenkins 2.358 but do not see the problem in Jenkins 2.357 or Jenkins 2.356.

          I believe the problem is that the emailext template plugin has a groovy script file, sidepanel.groovy, that is calling the singletonList method that was deprecated in Jenkins 2.358 by pull request 6740

          Mark Waite added a comment - - edited I also see the problem in Jenkins 2.358 but do not see the problem in Jenkins 2.357 or Jenkins 2.356. I believe the problem is that the emailext template plugin has a groovy script file, sidepanel.groovy , that is calling the singletonList method that was deprecated in Jenkins 2.358 by pull request 6740

          Basil Crow added a comment -

          I wonder if these Jelly usages are affected or if the only manifestation of this problem is the Groovy template in emailext-template.

          https://github.com/jenkinsci/depgraph-view-plugin/blob/626a9068b4c8971a8b8cac85847e4b6d3497991a/src/main/resources/hudson/plugins/depgraph_view/AbstractDependencyGraphAction/sidepanel.jelly#L34
          https://github.com/jenkinsci/deployer-framework-plugin/blob/acdbcf4a132481ca21523cbfe160758968180ef3/src/main/resources/com/cloudbees/plugins/deployer/DeployNowComputer/sidepanel.jelly#L35
          https://github.com/jenkinsci/htmlresource-plugin/blob/a10c444cc158ec1413a7095800e22096981da43f/src/main/resources/com/cwctravel/jenkinsci/plugins/htmlresource/HTMLResourceManagement/sidepanel.jelly#L35
          https://github.com/jenkinsci/implied-labels-plugin/blob/a182b605819f1a7a366a9c278a1bb7a0ac01ff45/src/main/resources/org/jenkinsci/plugins/impliedlabels/Config/configure.jelly#L33
          https://github.com/jenkinsci/implied-labels-plugin/blob/a182b605819f1a7a366a9c278a1bb7a0ac01ff45/src/main/resources/org/jenkinsci/plugins/impliedlabels/Config/index.jelly#L56
          https://github.com/jenkinsci/openstack-cloud-plugin/blob/4830e314d47c967a2f0825f563e171b9fda61e47/plugin/src/main/resources/jenkins/plugins/openstack/compute/JCloudsComputer/sidepanel.jelly#L53
          https://github.com/jenkinsci/puppet-enterprise-pipeline-plugin/blob/ee775cb9b27bbaae2a7cb9476b4862bf4ea32fcc/src/main/resources/org/jenkinsci/plugins/puppetenterprise/api/HieraDataStore/sidepanel.jelly#L10
          https://github.com/jenkinsci/puppet-enterprise-pipeline-plugin/blob/ee775cb9b27bbaae2a7cb9476b4862bf4ea32fcc/src/main/resources/org/jenkinsci/plugins/puppetenterprise/PuppetEnterpriseManagement/sidepanel.jelly#L10
          https://github.com/jenkinsci/scriptler-plugin/blob/241b25b9ff661fbd38cbd80ea04ff17cbe74b84a/src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagement/sidepanel.jelly#L46
          https://github.com/jenkinsci/shared-objects-plugin/blob/fe155953535097e9787814db47a67fbb856f7796/src/main/resources/org/jenkinsci/plugins/sharedobjects/SharedObjectManagementResult/sidepanel.jelly#L7

          Basil Crow added a comment - I wonder if these Jelly usages are affected or if the only manifestation of this problem is the Groovy template in emailext-template . https://github.com/jenkinsci/depgraph-view-plugin/blob/626a9068b4c8971a8b8cac85847e4b6d3497991a/src/main/resources/hudson/plugins/depgraph_view/AbstractDependencyGraphAction/sidepanel.jelly#L34 https://github.com/jenkinsci/deployer-framework-plugin/blob/acdbcf4a132481ca21523cbfe160758968180ef3/src/main/resources/com/cloudbees/plugins/deployer/DeployNowComputer/sidepanel.jelly#L35 https://github.com/jenkinsci/htmlresource-plugin/blob/a10c444cc158ec1413a7095800e22096981da43f/src/main/resources/com/cwctravel/jenkinsci/plugins/htmlresource/HTMLResourceManagement/sidepanel.jelly#L35 https://github.com/jenkinsci/implied-labels-plugin/blob/a182b605819f1a7a366a9c278a1bb7a0ac01ff45/src/main/resources/org/jenkinsci/plugins/impliedlabels/Config/configure.jelly#L33 https://github.com/jenkinsci/implied-labels-plugin/blob/a182b605819f1a7a366a9c278a1bb7a0ac01ff45/src/main/resources/org/jenkinsci/plugins/impliedlabels/Config/index.jelly#L56 https://github.com/jenkinsci/openstack-cloud-plugin/blob/4830e314d47c967a2f0825f563e171b9fda61e47/plugin/src/main/resources/jenkins/plugins/openstack/compute/JCloudsComputer/sidepanel.jelly#L53 https://github.com/jenkinsci/puppet-enterprise-pipeline-plugin/blob/ee775cb9b27bbaae2a7cb9476b4862bf4ea32fcc/src/main/resources/org/jenkinsci/plugins/puppetenterprise/api/HieraDataStore/sidepanel.jelly#L10 https://github.com/jenkinsci/puppet-enterprise-pipeline-plugin/blob/ee775cb9b27bbaae2a7cb9476b4862bf4ea32fcc/src/main/resources/org/jenkinsci/plugins/puppetenterprise/PuppetEnterpriseManagement/sidepanel.jelly#L10 https://github.com/jenkinsci/scriptler-plugin/blob/241b25b9ff661fbd38cbd80ea04ff17cbe74b84a/src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagement/sidepanel.jelly#L46 https://github.com/jenkinsci/shared-objects-plugin/blob/fe155953535097e9787814db47a67fbb856f7796/src/main/resources/org/jenkinsci/plugins/sharedobjects/SharedObjectManagementResult/sidepanel.jelly#L7

          Mark Waite added a comment -

          I checked the implied labels plugin and was able to use the page that references h.singletonList without issue in Jenkins 2.361.1. However, that reference is coming from a jelly file, while the reference in emailext-template-plugin is coming from a groovy file.

          I'm not sure why a reference from groovy would report a null pointer exception while a reference from jelly does not report a null pointer exception. I'm removing the use of h.singletonList from the implied labels plugin jelly files in PR-61.

          Mark Waite added a comment - I checked the implied labels plugin and was able to use the page that references h.singletonList without issue in Jenkins 2.361.1. However, that reference is coming from a jelly file, while the reference in emailext-template-plugin is coming from a groovy file. I'm not sure why a reference from groovy would report a null pointer exception while a reference from jelly does not report a null pointer exception. I'm removing the use of h.singletonList from the implied labels plugin jelly files in PR-61 .

          Mark Waite added a comment -

          compatriot, youngyea, and gamentek could you test drive the incremental build with my change to see if it works in your environment? I'm not a user of the email extension template plugin, so I can't be sure that the change did not introduce some ugly side effect.

          Mark Waite added a comment - compatriot , youngyea , and gamentek could you test drive the incremental build with my change to see if it works in your environment? I'm not a user of the email extension template plugin, so I can't be sure that the change did not introduce some ugly side effect.

          Basil Crow added a comment -

          If the NPE had affected all of the above plugins, I would have considered a revert of the original core PR. But if the NPE only affects emailext-template and a fix is already out for review, then going that route seems fine to me.

          Basil Crow added a comment - If the NPE had affected all of the above plugins, I would have considered a revert of the original core PR. But if the NPE only affects emailext-template and a fix is already out for review, then going that route seems fine to me.

          Jesse Glick added a comment -

          While avoiding the now-deprecated function is fine so far as it does, I believe the problem was misdiagnosed and that this is a regression from https://github.com/jenkinsci/jenkins/pull/6700.

          Jesse Glick added a comment - While avoiding the now-deprecated function is fine so far as it does, I believe the problem was misdiagnosed and that this is a regression from https://github.com/jenkinsci/jenkins/pull/6700 .

          Mark Waite added a comment -

          Thanks for the clarification and correction jglick.

          Mark Waite added a comment - Thanks for the clarification and correction jglick .

          markewaite I won't be able to check it for next 3 weeks, anyways if configuration page will be visible on clean installz then it should be fine

          Martin Compatriot added a comment - markewaite I won't be able to check it for next 3 weeks, anyways if configuration page will be visible on clean installz then it should be fine

          Rob Brunelle added a comment - - edited

          I tested creating a new template with the "Failure - Any" and Status Changed" conditions, which I use the most and everything seems to work just fine. Also, this may be an already existing issue but the field sizing on the config screen is a bit off (see screenshot-1). It's been a while since I've had to update any of the templates.

          Rob Brunelle added a comment - - edited I tested creating a new template with the "Failure - Any" and Status Changed" conditions, which I use the most and everything seems to work just fine. Also, this may be an already existing issue but the field sizing on the config screen is a bit off (see screenshot-1). It's been a while since I've had to update any of the templates.

          Mark Waite added a comment - - edited

          Thanks gamentek. I saw that the field sizing on the configuration screen needs to be fixed. I assume that there are a number of UI related changes that the plugin needs in order to use the guidelines from the Jenkins design library. It would be a help if you could open an issue that notes areas where the UI components need to be fixed. I can see some places where icons are missing and others where the table layout is incorrect.

          Mark Waite added a comment - - edited Thanks gamentek . I saw that the field sizing on the configuration screen needs to be fixed. I assume that there are a number of UI related changes that the plugin needs in order to use the guidelines from the Jenkins design library . It would be a help if you could open an issue that notes areas where the UI components need to be fixed. I can see some places where icons are missing and others where the table layout is incorrect.

            markewaite Mark Waite
            compatriot Martin Compatriot
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: