Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69379

Don't place yui-button class on jenkins-buttons

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • credentials-plugin
    • Jenkins 2.364, Credentials plugin 1139.veb_9579fca_33b_
    • 1224.vc23ca_a_9a_2cb_0

      The following scenario can be seen in locations, where you can add credentials through the credentials plugin.

      The "+ Add" button is a jenkins-button, as it should be, but its wrapped into a span adding yui-button on top of it, which displays two buttons, like we can see on the screenshot. The grey background is the hover effect of the jenkins-button and the blue frame is the hover effect of the yui-button.

      I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons.

        1. button.png
          82 kB
          Alexander Brandes

          [JENKINS-69379] Don't place yui-button class on jenkins-buttons

          James Nord added a comment -

          > I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons.

          I believe it may be all part of the ability to Add things on the fly and create the credential popup.
          https://github.com/jenkinsci/credentials-plugin/blob/839a6357c9b7c9c91bd86516b6de34a9cce595d3/src/main/resources/lib/credentials/select/select.js#L182-L216

          James Nord added a comment - > I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons. I believe it may be all part of the ability to Add things on the fly and create the credential popup. https://github.com/jenkinsci/credentials-plugin/blob/839a6357c9b7c9c91bd86516b6de34a9cce595d3/src/main/resources/lib/credentials/select/select.js#L182-L216

          Julie Heard added a comment -

          I have been having a look into this and I have several ways to fix it. The first one is here in a draft PR: https://github.com/jenkinsci/credentials-plugin/pull/422

          I put it in a draft as I wanted to discuss if this is the correct approach (it certainly looks the best aesthetically).

          Julie Heard added a comment - I have been having a look into this and I have several ways to fix it. The first one is here in a draft PR: https://github.com/jenkinsci/credentials-plugin/pull/422 I put it in a draft as I wanted to discuss if this is the correct approach (it certainly looks the best aesthetically).

          Julie Heard added a comment -

          PR is merged, now waiting for a new release of the plugin with the fix included

          Julie Heard added a comment - PR is merged, now waiting for a new release of the plugin with the fix included

          Mark Waite added a comment -

          Thanks for that julieheard! I've confirmed that the problem is fixed in credentials plugin 1224.vc23ca_a_9a_2cb_0

          Mark Waite added a comment - Thanks for that julieheard ! I've confirmed that the problem is fixed in credentials plugin 1224.vc23ca_a_9a_2cb_0

            julieheard Julie Heard
            notmyfault Alexander Brandes
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: