Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7026

Console view Ant target highlight cannot cope with colon in target name.

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • ant-plugin
    • None

    Description

      Only the part up to and including the first colon is highlighted.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          voorth voorth added a comment -

          Looks like allowing colons would simplify the regex in AntTargetNote.java to

          .*(?=:)

          unless you want to rule out a colon as start character, of course

          voorth voorth added a comment - Looks like allowing colons would simplify the regex in AntTargetNote.java to .*(?=:) unless you want to rule out a colon as start character, of course
          voorth voorth added a comment -

          console output looks like this:

          test:prepare:

          test:generate:

          test:compile:
          [echo] src.test.dir=/data01/buildserver/swarm-client/workspace/TRUNK_MGS/mgs/modules/core-ext/src/test
          [echo] build.test.classes.dir=/data01/buildserver/swarm-client/workspace/TRUNK_MGS/target/build/mgs-ext-test/WEB-INF/classes

          and the corresponding links in the ant target sidebar look like:

          test
          test
          test

          voorth voorth added a comment - console output looks like this: test :prepare: test :generate: test :compile: [echo] src.test.dir=/data01/buildserver/swarm-client/workspace/TRUNK_MGS/mgs/modules/core-ext/src/test [echo] build.test.classes.dir=/data01/buildserver/swarm-client/workspace/TRUNK_MGS/target/build/mgs-ext-test/WEB-INF/classes and the corresponding links in the ant target sidebar look like: test test test
          voorth voorth added a comment -

          A small patch that just replaces the used regex.
          Needs to be tested, since I have not been able to get Hudson building on my machin.

          I did test the regex on different target names, though.

          voorth voorth added a comment - A small patch that just replaces the used regex. Needs to be tested, since I have not been able to get Hudson building on my machin. I did test the regex on different target names, though.
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/tasks/_ant/AntTargetNote.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/33897
          Log:
          [FIXED JENKINS-7026] applied the patch to fix the regular expression.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/tasks/_ant/AntTargetNote.java trunk/www/changelog.html http://jenkins-ci.org/commit/33897 Log: [FIXED JENKINS-7026] applied the patch to fix the regular expression.
          dogfood dogfood added a comment -

          Integrated in hudson_main_trunk #186
          [FIXED JENKINS-7026] applied the patch to fix the regular expression.

          kohsuke :
          Files :

          • /trunk/www/changelog.html
          • /trunk/hudson/main/core/src/main/java/hudson/tasks/_ant/AntTargetNote.java
          dogfood dogfood added a comment - Integrated in hudson_main_trunk #186 [FIXED JENKINS-7026] applied the patch to fix the regular expression. kohsuke : Files : /trunk/www/changelog.html /trunk/hudson/main/core/src/main/java/hudson/tasks/_ant/AntTargetNote.java

          People

            Unassigned Unassigned
            voorth voorth
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: