Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70778

Use modern build status icon instead of "ball-"

      The embeddable build status plugin still relies on the colored balls, as seen on https://ci.jenkins.io/job/Core/job/stapler/job/master/badge/ for example.

      You can reference them via `ball-<size>`.

      However, Jenkins does no longer use colored balls to display a build status. The legend displays the different states of build statuses: https://ci.jenkins.io/legend

      Instead of manually inserting the colored ball PNGs, the embeddable-build-status plugin should make use of the API, to display the appropriate build status icons, you can find in other occasions in Jenkins.

          [JENKINS-70778] Use modern build status icon instead of "ball-"

          Rishav added a comment -

          Couldn't recreate this issue. Tried building a freestyle project and found modern icons being used. Also, the only occurrence of "ball-" I found were present in two tests. Is this issue closed?

          Rishav added a comment - Couldn't recreate this issue. Tried building a freestyle project and found modern icons being used. Also, the only occurrence of "ball-" I found were present in two tests. Is this issue closed?

          Amit added a comment -

          devrish could you please tell me how to contribute here as i'm aware of github how to contribute through that but this is Jenkins own website how can i contribute through this?

           

          Amit added a comment - devrish could you please tell me how to contribute here as i'm aware of github how to contribute through that but this is Jenkins own website how can i contribute through this?  

          Rishav added a comment - - edited

          amit4688  The code repositories that you need to contribute to are present on Github. This application is JIRA, it is used for keeping track of issues, not for code contribution. Check the `Component` information in the issue descripton, and search for the relevant repository under jenkinsci or jenkins-infra Github organisations.

          Any progress you make is to be discussed here, but the contribution is to be done on Github.

          Rishav added a comment - - edited amit4688   The code repositories that you need to contribute to are present on Github. This application is JIRA, it is used for keeping track of issues, not for code contribution. Check the `Component` information in the issue descripton, and search for the relevant repository under jenkinsci or jenkins-infra Github organisations. Any progress you make is to be discussed here, but the contribution is to be done on Github.

          Felipe Santos added a comment -

          I would appreciate this improvement as well. This would make some internal markdown pages I have a lot nicer.

          Not to mention it would finally "fix" the successful color from blue to green.

          Felipe Santos added a comment - I would appreciate this improvement as well. This would make some internal markdown pages I have a lot nicer. Not to mention it would finally "fix" the successful color from blue to green.

          Mark Waite added a comment - - edited

          felipecassiors I don't understand how you're using the embeddable build status plugin in a way that forces anyone to see the ball icons, other than you choosing to use those icons in the link that you embed. The embeddable build status page for each build, like badge page of the plugin's own build shows many different examples that embed the build status without a ball icon.

          As an example, I've embedded the Confluence form of the status icon below

          Yes, the plugin continues to allow users to use a colored icon if they wish, but that is only retained in the plugin in order to not break compatibility with existing users. I've embedded a Confluence example of the ball icon below to show that it is still operating as expected.

          Mark Waite added a comment - - edited felipecassiors I don't understand how you're using the embeddable build status plugin in a way that forces anyone to see the ball icons, other than you choosing to use those icons in the link that you embed. The embeddable build status page for each build, like badge page of the plugin's own build shows many different examples that embed the build status without a ball icon. As an example, I've embedded the Confluence form of the status icon below Yes, the plugin continues to allow users to use a colored icon if they wish, but that is only retained in the plugin in order to not break compatibility with existing users. I've embedded a Confluence example of the ball icon below to show that it is still operating as expected.

          Felipe Santos added a comment - - edited

          markewaite I have a "Changelog" markdown page with a badge for each release, where the ball style aligns and looks much better than the flat style.

          So, I would prefer to stick with the ball style for the badges, but if the ball style was updated from the legacy to the modern icons, my markdown page would look a lot nicer.

          Regarding green vs blue, I solved by installing the Green Balls plugin (even though it's marked as deprecated/obsolete, it still works for this purpose).

          Please let me know if there's any confusion left.

          Felipe Santos added a comment - - edited markewaite I have a "Changelog" markdown page with a badge for each release, where the ball style aligns and looks much better than the flat style. So, I would prefer to stick with the ball style for the badges, but if the ball style was updated from the legacy to the modern icons, my markdown page would look a lot nicer. Regarding green vs blue, I solved by installing the Green Balls plugin (even though it's marked as deprecated/obsolete, it still works for this purpose). Please let me know if there's any confusion left.

          Mark Waite added a comment -

          Thanks for the clarification.  I think that the plugin would need to be extended with a new capability to return the modern status image.  I don't think that the plugin should surprise other users by modifying the existing "ball" behavior, but should instead allow users to reference the modern status image through a different entry.

          Mark Waite added a comment - Thanks for the clarification.  I think that the plugin would need to be extended with a new capability to return the modern status image.  I don't think that the plugin should surprise other users by modifying the existing "ball" behavior, but should instead allow users to reference the modern status image through a different entry.

          Felipe Santos added a comment - - edited

          I agree, unless there are plans to deprecate the legacy balls in Jenkins, which I suspect to be true given the Green Balls plugin being marked as deprecated/obsolete.

          timja, since you worked on the new icons (https://github.com/jenkinsci/jenkins/pull/5065), and basil, since you deprecated Green Balls, would you have any insight on whether the legacy icons will be deprecated/removed?

          Felipe Santos added a comment - - edited I agree, unless there are plans to deprecate the legacy balls in Jenkins, which I suspect to be true given the Green Balls plugin being marked as deprecated/obsolete. timja , since you worked on the new icons ( https://github.com/jenkinsci/jenkins/pull/5065 ), and basil , since you deprecated Green Balls, would you have any insight on whether the legacy icons will be deprecated/removed?

          Basil Crow added a comment -

          would you have any insight

          I have no such insight

          Basil Crow added a comment - would you have any insight I have no such insight

          Felipe Santos added a comment -

          markewaite, as long as it is possible to retain the same functionality of the existing balls (e.g. can provide the same sizes as the existing balls to not break any design relying on these sizes), I would say all users would probably appreciate being "surprised" with the new design.

          Felipe Santos added a comment - markewaite , as long as it is possible to retain the same functionality of the existing balls (e.g. can provide the same sizes as the existing balls to not break any design relying on these sizes), I would say all users would probably appreciate being "surprised" with the new design.

            Unassigned Unassigned
            notmyfault Alexander Brandes
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: