Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70837

Credential UI shows giant plus sign in Firefox (102esr) is back

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • credentials-plugin
    • Jenkins 2.375.3
      credential-plugin 1224.vc23ca_a_9a_2cb_0
      Mozilla Firefox 102.9.0esr (64-bit)

      Same visual bug from JENKINS-68163

      Occurring after fix JENKINS-69379 where obsolete styling in the Add button was removed.

          [JENKINS-70837] Credential UI shows giant plus sign in Firefox (102esr) is back

          Alexander Brandes added a comment - - edited

          Please don't assign individuals to issues, unless the individual explicitly stated they are willing to contribute to an issue. 

          I'm not interested in contributing to issues occurring in specific plugins for Firefox ESR versions only.

          I have unassigned myself.

          However, you are very welcome to contribute a fix towards the credentials plugin

          Alexander Brandes added a comment - - edited Please don't assign individuals to issues, unless the individual explicitly stated they are willing to contribute to an issue.  I'm not interested in contributing to issues occurring in specific plugins for Firefox ESR versions only. I have unassigned myself. However, you are very welcome to contribute a fix towards the credentials plugin

          Frederick added a comment - - edited

          Sorry. I thought you would be interested since you were assigned to last similar one. My bad and not gonna happen again.

          Frederick added a comment - - edited Sorry. I thought you would be interested since you were assigned to last similar one. My bad and not gonna happen again.

          I see this bug on Firefox 102.9.0esr, when using Credentials Plugin Version 1224.vc23ca_a_9a_2cb_0 on Jenkins 2.387.1.

          I don't see this bug with Firefox Developer Edition 112.0b9 (64-bit), nor with Microsoft Edge Version 111.0.1661.62 (Official build). In those Web browsers, the add credentials button has no visible graphic in it. Apparently, the plus sign exists there but it is scaled to zero size (or almost that) due to the browser style flex-shrink: 1.

          Because the plus sign does not show up in those two browsers, and other dropdown buttons such the "Add" button under "Additional Behaviours" in pipeline configuration do not have any graphics, I think it would be OK to delete the plus sign from the add credentials button. I mean delete <l:icon src="symbol-add"/> from src/main/resources/lib/credentials/select.jelly#L120 and perhaps also from src/main/resources/lib/credentials/select.jelly#L152.

          Kalle Niemitalo added a comment - I see this bug on Firefox 102.9.0esr, when using Credentials Plugin Version 1224.vc23ca_a_9a_2cb_0 on Jenkins 2.387.1. I don't see this bug with Firefox Developer Edition 112.0b9 (64-bit), nor with Microsoft Edge Version 111.0.1661.62 (Official build). In those Web browsers, the add credentials button has no visible graphic in it. Apparently, the plus sign exists there but it is scaled to zero size (or almost that) due to the browser style flex-shrink: 1 . Because the plus sign does not show up in those two browsers, and other dropdown buttons such the "Add" button under "Additional Behaviours" in pipeline configuration do not have any graphics, I think it would be OK to delete the plus sign from the add credentials button. I mean delete <l:icon src="symbol-add"/> from src/main/resources/lib/credentials/select.jelly#L120 and perhaps also from src/main/resources/lib/credentials/select.jelly#L152 .

          Alexander Brandes added a comment - - edited

          > I am using FireFox, I see that might be relevant from past similar issues.

          The plus is giant on firefox, but slightly oversized on other browsers too.

          I recommend switching away from YUI elements to APIs provided by core, which is no longer reliant on YUI for buttons, to resolve this incident and prevent future ones.

          Alexander Brandes added a comment - - edited > I am using FireFox, I see that might be relevant from past similar issues. The plus is giant on firefox, but slightly oversized on other browsers too. I recommend switching away from YUI elements to APIs provided by core, which is no longer reliant on YUI for buttons, to resolve this incident and prevent future ones.

          According to https://www.mozilla.org/firefox/organizations/notes/ and https://whattrainisitnow.com/calendar/, Firefox ESR versions 102.13 and 115.0 were released this week. Perhaps 115.0 fixes the giant plus sign. However, a previously installed Firefox ESR automatically updated to 102.13.0esr and not to 115.0esr, so one cannot yet expect users to have 115.0esr.

          Kalle Niemitalo added a comment - According to https://www.mozilla.org/firefox/organizations/notes/ and https://whattrainisitnow.com/calendar/ , Firefox ESR versions 102.13 and 115.0 were released this week. Perhaps 115.0 fixes the giant plus sign. However, a previously installed Firefox ESR automatically updated to 102.13.0esr and not to 115.0esr, so one cannot yet expect users to have 115.0esr.

          Can confirm that 102.15.1esr still has this issue. Upgrading to 115.2.1esr does fix it though.

          Matthew Ludlum added a comment - Can confirm that 102.15.1esr still has this issue. Upgrading to 115.2.1esr does fix it though.

            Unassigned Unassigned
            fredp Frederick
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: