-
Improvement
-
Resolution: Fixed
-
Major
-
None
-
Hudson 1.369
This will be used by the Timestamper plugin to insert a timestamp on each line of the BuildListener output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as JENKINS-7111.)
Preferred Approach (JENKINS-7112_decorateLogger.patch)
Add a decorateLogger method to the BuildWrapper class, which can be optionally overridden to wrap the BuildListener's default logger.
Alternate Approach (JENKINS-7112.patch)
Add a decorateBuildListener method to the BuildWrapper class, which can be optionally overridden to wrap the default BuildListener. I have decided to not use this approach, since:
- Other than wrapping the logger, it doesn't seem useful for plugins to alter the behaviour of the BuildListener.
- It would make it more difficult to evolve the BuildListener interface in future.
Both patches were created from the directory:
https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/
Will ask for feedback from the dev mailing list before proceeding.
- is blocking
-
JENKINS-7111 Timestamper plugin causes Mercurial update to fail?
-
- Closed
-
[JENKINS-7112] Allow plugins to transform the BuildListener log output.
Attachment | New: JENKINS-7112.patch [ 19631 ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Link |
New:
This issue is blocking |
Attachment | New: JENKINS-7112_decorateLogger.patch [ 19644 ] |
Description |
Original:
Add a {{decorateBuildListener}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the default {{BuildListener}}. See the attached patch for the proposed implementation. Patch was created from the directory: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/ This will be used by the {{Timestamper}} plugin to insert a timestamp on each line of the {{BuildListener}} output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as Will ask for feedback from the dev mailing list before proceeding. |
New:
This will be used by the {{Timestamper}} plugin to insert a timestamp on each line of the {{BuildListener}} output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as ----- *Preferred Approach* ({{ Add a {{decorateLogger}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the {{BuildListener}}'s default logger. ----- *Alternate Approach* ({{ Add a {{decorateBuildListener}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the default {{BuildListener}}. I have decided to not use this approach, since: * Other than wrapping the logger, it doesn't seem useful for plugins to alter the behaviour of the {{BuildListener}}. * It would make it more difficult to evolve the {{BuildListener}} interface in future. ----- Both patches were created from the directory: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/ Will ask for feedback from the dev mailing list before proceeding. |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
Reminder: The @since tag may need to be updated before committing.