Details
-
Improvement
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
Hudson 1.369
Description
This will be used by the Timestamper plugin to insert a timestamp on each line of the BuildListener output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as JENKINS-7111.)
Preferred Approach (JENKINS-7112_decorateLogger.patch)
Add a decorateLogger method to the BuildWrapper class, which can be optionally overridden to wrap the BuildListener's default logger.
Alternate Approach (JENKINS-7112.patch)
Add a decorateBuildListener method to the BuildWrapper class, which can be optionally overridden to wrap the default BuildListener. I have decided to not use this approach, since:
- Other than wrapping the logger, it doesn't seem useful for plugins to alter the behaviour of the BuildListener.
- It would make it more difficult to evolve the BuildListener interface in future.
Both patches were created from the directory:
https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/
Will ask for feedback from the dev mailing list before proceeding.
Attachments
Issue Links
- is blocking
-
JENKINS-7111 Timestamper plugin causes Mercurial update to fail?
-
- Closed
-
Activity
Steven G Brown
created issue -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | JENKINS-7112.patch [ 19631 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Link |
This issue is blocking |
| Attachment | JENKINS-7112_decorateLogger.patch [ 19644 ] |
| Description |
Add a {{decorateBuildListener}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the default {{BuildListener}}. See the attached patch for the proposed implementation. Patch was created from the directory: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/ This will be used by the {{Timestamper}} plugin to insert a timestamp on each line of the {{BuildListener}} output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as Will ask for feedback from the dev mailing list before proceeding. |
This will be used by the {{Timestamper}} plugin to insert a timestamp on each line of the {{BuildListener}} output. (Currently it modifies the launcher output instead, which can have unwanted side-effects such as ----- *Preferred Approach* ({{ Add a {{decorateLogger}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the {{BuildListener}}'s default logger. ----- *Alternate Approach* ({{ Add a {{decorateBuildListener}} method to the {{BuildWrapper}} class, which can be optionally overridden to wrap the default {{BuildListener}}. I have decided to not use this approach, since: * Other than wrapping the logger, it doesn't seem useful for plugins to alter the behaviour of the {{BuildListener}}. * It would make it more difficult to evolve the {{BuildListener}} interface in future. ----- Both patches were created from the directory: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main/core/ Will ask for feedback from the dev mailing list before proceeding. |
Code changed in hudson
User: : StevenGBrown
Path:
trunk/hudson/main/core/src/main/java/hudson/model/Run.java
trunk/hudson/main/core/src/main/java/hudson/tasks/BuildWrapper.java
trunk/www/changelog.html
http://jenkins-ci.org/commit/34008
Log:
[FIXED JENKINS-7112] Plugins can now transform the console output.
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
Integrated in 
hudson_main_trunk #201
[FIXED JENKINS-7112] Plugins can now transform the console output.
StevenGBrown :
Files :
- /trunk/www/changelog.html
- /trunk/hudson/main/core/src/main/java/hudson/model/Run.java
- /trunk/hudson/main/core/src/main/java/hudson/tasks/BuildWrapper.java
Steven G Brown
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Workflow | JNJira [ 137209 ] | JNJira + In-Review [ 204426 ] |
Reminder: The @since tag may need to be updated before committing.