Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71364

p4 plugin not syncing to same changeset in matrix build

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • p4-plugin
    • None

      A matrix build is supposed to sync on the same changeset for all versions of the builds running on all slaves.

      When jobs are scheduled one after another and take some time, they sync on the latest commit, where they should sync to the last commit before the toplevel build started.

      The previous version of the perforce plugin did this correct.

          [JENKINS-71364] p4 plugin not syncing to same changeset in matrix build

          Heiko Nardmann added a comment - - edited

          Is this related to JENKINS-65246 and/or JENKINS-63879?

          Heiko Nardmann added a comment - - edited Is this related to JENKINS-65246 and/or JENKINS-63879 ?

          lode leroy added a comment - - edited

          @Heiko: I don't think it's related, it's a different problem:

          when running a matrix build with builds that take some time, the sub-builds can be of different commits.

          in our case, the sub-builds share the same (very big) workspace and take quite some time, when they sync to different commits, it happens that sub-builds fail - even though a build of each commit would work, builds that are partially of one commit and partially of the next sometimes fail. (because a different sub build syncs the workspace to another commit during other sub-builds running in parallel)

          lode leroy added a comment - - edited @Heiko: I don't think it's related, it's a different problem: when running a matrix build with builds that take some time, the sub-builds can be of different commits. in our case, the sub-builds share the same (very big) workspace and take quite some time, when they sync to different commits, it happens that sub-builds fail - even though a build of each commit would work, builds that are partially of one commit and partially of the next sometimes fail. (because a different sub build syncs the workspace to another commit during other sub-builds running in parallel)

          lode leroy added a comment - - edited

          I've been looking at the code a bit, and I have the impression that the line

                      p4-plugin/src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java : 610

          should be 

                      if (job instanceof MatrixConfiguration) {

          instead of 

                      if (job instanceof MatrixProject) {

           

          see also

                     https://github.com/jenkinsci/p4-plugin/pull/189

          for a potential fix

           

          lode leroy added a comment - - edited I've been looking at the code a bit, and I have the impression that the line             p4-plugin/src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java : 610 should be              if (job instanceof MatrixConfiguration) { instead of              if (job instanceof MatrixProject) {   see also             https://github.com/jenkinsci/p4-plugin/pull/189 for a potential fix  

            Unassigned Unassigned
            lleroy lode leroy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: