Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71741

global-build-stats AJAX request uses undefined field (regression in 2.405)

XMLWordPrintable

    • 282.v79ca_e079d1b_1

          [JENKINS-71741] global-build-stats AJAX request uses undefined field (regression in 2.405)

          Basil Crow added a comment -

          timja FYI

          Basil Crow added a comment - timja FYI

          Tim Jacomb added a comment - - edited

          I've looked into this, I don't think there's a lot of point in fixing this without doing the rest of the prototype work.

          Unfortunately this plugin uses more Prototype than any other plugin I have seen and it's quite difficult to update.

          The plugin uses many deprecated and weird patterns.

          It has no documentation and has an unresolved security warning.

          It does have 6000 installations though so I guess we still want to solve this? 

           

          (The security vulnerability may have been fixed in https://github.com/jenkinsci/global-build-stats-plugin/pull/38 but it hasn't been released since)

           

          cc markwaite 

           

          My changes can be found in https://github.com/jenkinsci/global-build-stats-plugin/compare/master...timja:global-build-stats-plugin:die-prototype?expand=1 but likely a ways off getting it working

          Tim Jacomb added a comment - - edited I've looked into this, I don't think there's a lot of point in fixing this without doing the rest of the prototype work. Unfortunately this plugin uses more Prototype than any other plugin I have seen and it's quite difficult to update. The plugin uses many deprecated and weird patterns. It has no documentation and has an unresolved security warning. It does have 6000 installations though so I guess we still want to solve this?    (The security vulnerability may have been fixed in https://github.com/jenkinsci/global-build-stats-plugin/pull/38 but it hasn't been released since)   cc markwaite     My changes can be found in https://github.com/jenkinsci/global-build-stats-plugin/compare/master...timja:global-build-stats-plugin:die-prototype?expand=1 but likely a ways off getting it working

          Mark Waite added a comment -

          Thanks for investigating timja. https://github.com/jenkinsci/global-build-stats-plugin/pull/49 is also an effort by victor_yousician to remove the Prototype.js usage from the plugin. His efforts show the many locations where that plugin is using Prototype.js as well.

          Mark Waite added a comment - Thanks for investigating timja . https://github.com/jenkinsci/global-build-stats-plugin/pull/49 is also an effort by victor_yousician to remove the Prototype.js usage from the plugin. His efforts show the many locations where that plugin is using Prototype.js as well.

          Tim Jacomb added a comment -

          I see, I tested it and I didn't notice any issues that weren't pre-existing with the master branch.

          Tim Jacomb added a comment - I see, I tested it and I didn't notice any issues that weren't pre-existing with the master branch.

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: