Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71905

Proxy error links improperly uses root URL (regression in 2.408)

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core

      Steps to reproduce

      1. Disconnect from the internet (e.g. toggle wifi)
      2. Start Jenkins (e.g. docker run -p 8080:8080 jenkins/jenkins)
      3. Log in, skip everything in setup wizard ("Skip Plugin Installations", "Continue as admin", "not now", "Start using Jenkins")
      4. Go to Manage Jenkins » Plugins » Download progress and click the first link labeled "configure HTTP proxy?"

      Expected result

      The link works

      Actual result

      The link takes you to http://localhost:8080/manage/pluginManager/updates/nullmanage/pluginManager/advanced because the Root URL is null at this point (and the fallback to request URL didn't work).

      Notes

      Introduced in https://github.com/jenkinsci/jenkins/pull/7992 

      The first error on the Download progress page was logged when Jenkins started, so it would not pick up a URL configured during the wizard.

          [JENKINS-71905] Proxy error links improperly uses root URL (regression in 2.408)

          Tim Jacomb added a comment -

          Is this bug actually valid?

          All you need to do to fix it is configure a root URL.

          Tim Jacomb added a comment - Is this bug actually valid? All you need to do to fix it is configure a root URL.

          There is related advice "Rule #1: no absolute URLs in hyperlinks" in Jenkins : Hyperlinks in HTML, which is marked as deprecated but is still linked from Views in the developer guide.

          Kalle Niemitalo added a comment - There is related advice "Rule #1: no absolute URLs in hyperlinks" in Jenkins : Hyperlinks in HTML , which is marked as deprecated but is still linked from Views in the developer guide.

          Daniel Beck added a comment -

          All you need to do to fix it is configure a root URL.

          As I wrote in the description,

          The first error on the Download progress page was logged when Jenkins started, so it would not pick up a URL configured during the wizard.

          Additionally, the errors record the configured/used (as fallback) root URL, not the actually used root URL; which is still a problem to have in the UI.

          Daniel Beck added a comment - All you need to do to fix it is configure a root URL. As I wrote in the description, The first error on the Download progress page was logged when Jenkins started, so it would not pick up a URL configured during the wizard. Additionally, the errors record the configured/used (as fallback) root URL, not the actually used root URL; which is still a problem to have in the UI.

            Unassigned Unassigned
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: