Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72030

Remove (or ability to disable/remove) logo retrieval from retrieveActions

XMLWordPrintable

    • github-branch-source:1767.va_7d01ea_c7256

      We should provide a way to disable the retrieval of the org logo from org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.retrieveActions that hangs the Organization Item scans when the anonymous user API quota in GitHub is reached.

      An Org Scan consumes an anonymous call. And even with the cache implemented as part of https://issues.jenkins.io/browse/JENKINS-69815, this is a problem because if another source consumes the anonymous user quota from within the same network (from behind the same single IP for example) all instances may be impacted.

      Note that at the moment, even looking at the config page consumes an API call: https://issues.jenkins.io/browse/JENKINS-71887.

      As noted in https://github.com/jenkinsci/github-branch-source-plugin/pull/700#issuecomment-1710750053, we better remove that behavior from retrieveActions

          [JENKINS-72030] Remove (or ability to disable/remove) logo retrieval from retrieveActions

          Allan BURDAJEWICZ added a comment - - edited

          Also, in the configuration of an Org item, we can configure a *Appearance > Icon* that by default is the metadata icon. But even if we select something different, the SCMNavigator is still gonna fetch the AvatarMetadataAction. That seems like a design flaw ?
          If choosing another FolderIcon here would turn off the fetch for the avatar, that would be a solution for the problem that we are trying to fix...

          Allan BURDAJEWICZ added a comment - - edited Also, in the configuration of an Org item, we can configure a * Appearance > Icon * that by default is the metadata icon . But even if we select something different, the SCMNavigator is still gonna fetch the AvatarMetadataAction. That seems like a design flaw ? If choosing another FolderIcon here would turn off the fetch for the avatar, that would be a solution for the problem that we are trying to fix...

          Allan BURDAJEWICZ added a comment -

          https://github.com/jenkinsci/github-branch-source-plugin/releases/tag/1767.va_7d01ea_c7256 is released. GitHub Org Folders have a “Enable Avatar“ checkbox that can be unchecked to disable the avatar fetch feature. This is disabled by default for newly created Org Folders.

          Allan BURDAJEWICZ added a comment - https://github.com/jenkinsci/github-branch-source-plugin/releases/tag/1767.va_7d01ea_c7256 is released. GitHub Org Folders have a “Enable Avatar“ checkbox that can be unchecked to disable the avatar fetch feature. This is disabled by default for newly created Org Folders.

            allan_burdajewicz Allan BURDAJEWICZ
            allan_burdajewicz Allan BURDAJEWICZ
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: