Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73034

Core PR #9167 doesn't do what it claims it does (regression in 2.453)

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core
    • Jenkins 2.454

      Per https://github.com/jenkinsci/jenkins/pull/9167#issuecomment-2063222418 the PR doesn't consistently do what it claims to do (disabling the OK button if there's a duplicate name).

      Considering this a regression because the behavior was consistent(ly suboptimal) before, and now is inconsistent.

          [JENKINS-73034] Core PR #9167 doesn't do what it claims it does (regression in 2.453)

          James Nord added a comment -

          janfaracik would you be able to take a look?

          James Nord added a comment - janfaracik would you be able to take a look?

          Basil Crow added a comment -

          As part of fixing this issue, the workaround in acceptance-test-harness should be removed per https://github.com/jenkinsci/acceptance-test-harness/issues/1549, and the core pull request should ensure that CreateItemTest#duplicate_item_name_displays_error is passing with the workaround removed.

          Basil Crow added a comment - As part of fixing this issue, the workaround in acceptance-test-harness should be removed per https://github.com/jenkinsci/acceptance-test-harness/issues/1549 , and the core pull request should ensure that CreateItemTest#duplicate_item_name_displays_error is passing with the workaround removed.

            Unassigned Unassigned
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: