Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73168

"No changes" does not appear (regression in 2.453)

    • 2.459

      Steps to reproduce

      Create a freestyle project with a build step that executes a shell command running ls, then build the project and go to http://${JENKINS_URL}/job/${JOB_NAME}/1/.

      Expected results

      Note

      These are the actual results on 2.452 and earlier.

      The text "No changes" is present on the page.

      Actual results

      The text "No changes" is not present on the page.

      Note

      Bisected to jenkinsci/jenkins#8110 by janfaracik.

          [JENKINS-73168] "No changes" does not appear (regression in 2.453)

          Basil Crow added a comment -

          As part of fixing this issue, the workaround in acceptance-test-harness should be removed per https://github.com/jenkinsci/acceptance-test-harness/issues/1548, and the core pull request should ensure that FreestyleJobTest#should_visit_build_with_permalink is passing with the workaround removed.

          Basil Crow added a comment - As part of fixing this issue, the workaround in acceptance-test-harness should be removed per https://github.com/jenkinsci/acceptance-test-harness/issues/1548 , and the core pull request should ensure that FreestyleJobTest#should_visit_build_with_permalink is passing with the workaround removed.

          Jan Faracik added a comment - - edited

          Opened a merge request for core here - https://github.com/jenkinsci/jenkins/pull/9283

          Jan Faracik added a comment - - edited Opened a merge request for core here - https://github.com/jenkinsci/jenkins/pull/9283

          Daniel Beck added a comment - - edited

          krisstern Why is this backported into 2.452.2 when it's a regression in 2.453? https://github.com/jenkinsci/jenkins/commit/ea7c71b237b2beaeaefe903ddd33ac9095547f9e isn't in 2.452.1.

          Daniel Beck added a comment - - edited krisstern Why is this backported into 2.452.2 when it's a regression in 2.453? https://github.com/jenkinsci/jenkins/commit/ea7c71b237b2beaeaefe903ddd33ac9095547f9e isn't in 2.452.1.

          Kris Stern added a comment -

          Sorry my bad danielbeck, I didn't check very carefully. Let me revert this change now. 

          Kris Stern added a comment - Sorry my bad danielbeck , I didn't check very carefully. Let me revert this change now. 

          Basil Crow added a comment -

          Sorry about that, you are right.

          Basil Crow added a comment - Sorry about that, you are right.

          Mark Waite added a comment -

          I removed the lts-candidate label because the fix is included in Jenkins 2.459 and later. Will be part of Jenkins 2.462.1

          Mark Waite added a comment - I removed the lts-candidate label because the fix is included in Jenkins 2.459 and later. Will be part of Jenkins 2.462.1

            janfaracik Jan Faracik
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: