Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74879

Pull Requests merged aren't differentiated in the UI

      Hello, 

      Since the update to 2.479.1, we had three PRs. One opened, and two merged. 
      We noticed two differences : 

      • The opened PR got renamed, not the two merged.
      • The merged PR aren't strikethrough like it was with previous LTS. 

      There is then no way to differentiate an opened, than a closed pull request : 

      If I look at the styling, I see that for the disabled PR, the class "disabledJob job-status disabled" if applied, but no strikethrough is visible.

          [JENKINS-74879] Pull Requests merged aren't differentiated in the UI

          Mark Waite added a comment -

          janfaracik is this one that you could investigate related to styling of disabled pull requests? I believe we see the behavior on ci.jenkins.io as well.

          Mark Waite added a comment - janfaracik is this one that you could investigate related to styling of disabled pull requests? I believe we see the behavior on ci.jenkins.io as well.

          Yoann added a comment -

          markewaite janfaracik Hello, would there be any update, or workaround for the reported issue ? Thank you for the work.

          Yoann added a comment - markewaite janfaracik Hello, would there be any update, or workaround for the reported issue ? Thank you for the work.

          Mark Waite added a comment - - edited

          When I look at the HTML markup on a ci.jenkins.io job, I see the <s> tag is wrapping the hyperlink in the table, but the text is not shown with strikethrough (at least not on my Chrome version). It looks like this:

          Since the <s> tag is there, I assumed that it would be rendered with strikethrough text.

          janfaracik any ideas what might be causing the strikethrough HTML tag to not be rendered as strikethrough text?

          Mark Waite added a comment - - edited When I look at the HTML markup on a ci.jenkins.io job, I see the <s> tag is wrapping the hyperlink in the table, but the text is not shown with strikethrough (at least not on my Chrome version). It looks like this: Since the <s> tag is there, I assumed that it would be rendered with strikethrough text. janfaracik any ideas what might be causing the strikethrough HTML tag to not be rendered as strikethrough text?

          Mark Waite added a comment - - edited

          My guess about CSS seems like it was on the right track. If I remove the jenkins-table__link class from that entry, then the strikethrough is rendered as strikethrough text.

          The text-decoration on __link seems to have been set to text-decoration: none !important in Jenkins core commit 608e41106ee as part of PR 6248 in Sep 2022. I'm not sure if it is better to remove the class in branch API plugin or change the class definition in Jenkins core.

          I'm going to assume that the change in branch API is a better choice and perform an experiment in the plugin to see how it behaves.

          Mark Waite added a comment - - edited My guess about CSS seems like it was on the right track. If I remove the jenkins-table__link class from that entry, then the strikethrough is rendered as strikethrough text. The text-decoration on __link seems to have been set to text-decoration: none !important in Jenkins core commit 608e41106ee as part of PR 6248 in Sep 2022. I'm not sure if it is better to remove the class in branch API plugin or change the class definition in Jenkins core. I'm going to assume that the change in branch API is a better choice and perform an experiment in the plugin to see how it behaves.

          Mark Waite added a comment -

          Change proposed in branch API plugin PR-501 looks like this in my testing:

          Mark Waite added a comment - Change proposed in branch API plugin PR-501 looks like this in my testing:

          Mark Waite added a comment -

          If others would like to test the proposed pull request, they can use the incremental build.

          Download link:

          Plugin Installation Manager input format:

          branch-api:incrementals;org.jenkins-ci.plugins;2.1205.vc84807b_e8204
          

          Mark Waite added a comment - If others would like to test the proposed pull request, they can use the incremental build. Download link: branch-api Plugin Installation Manager input format: branch-api:incrementals;org.jenkins-ci.plugins;2.1205.vc84807b_e8204

            markewaite Mark Waite
            yoann_d Yoann
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: