Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18065

AbstractLazyLoadRunMap.iterator() calls .all()

    XMLWordPrintable

Details

    Description

      Merely calling job.getBuilds().isEmpty() breaks lazy-loading:

      	at hudson.model.Run.onLoad(Run.java:319)
	at hudson.model.RunMap.retrieve(RunMap.java:226)
	at hudson.model.RunMap.retrieve(RunMap.java:59)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:667)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:650)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.all(AbstractLazyLoadRunMap.java:602)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.entrySet(AbstractLazyLoadRunMap.java:264)
	at java.util.AbstractMap$2$1.<init>(AbstractMap.java:378)
	at java.util.AbstractMap$2.iterator(AbstractMap.java:377)
	at hudson.util.RunList$2.iterator(RunList.java:213)
	at hudson.util.RunList.iterator(RunList.java:103)
	at hudson.util.RunList.isEmpty(RunList.java:173)

      You would reasonably expect this method, and anything simply iterating builds, to be lazy, but it is eager.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25655 AbstractLazyLoadRunMap.entrySet improperly cached

          • Major - Major loss of function.
          • Resolved
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20892 /{view,computer,user}/*/builds & /job/*/buildTimeTrend block HTTP response on build record loading

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23244 Slave build history page has no data and spawns a ton of very long-lived blocking threads on the master

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-8754 ROADMAP: Improve Start-up Time

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-8754 [ JENKINS-8754 ]
            jglick Jesse Glick made changes -
            Labels lts-candidate performance lazy-loading lts-candidate performance
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-20892 [ JENKINS-20892 ]
            jglick Jesse Glick made changes -
            Assignee Kohsuke Kawaguchi [ kohsuke ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-23244 [ JENKINS-23244 ]
            olivergondza Oliver Gondža made changes -
            Labels lazy-loading lts-candidate performance 1.565.2-fixed lazy-loading performance
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-25655 [ JENKINS-25655 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 149362 ] JNJira + In-Review [ 193087 ]

            People

              kohsuke Kohsuke Kawaguchi
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: