Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20892

/{view,computer,user}/*/builds & /job/*/buildTimeTrend block HTTP response on build record loading

    XMLWordPrintable

Details

    Description

      Computer/builds.jelly calls Computer.getBuilds which first looks up all Job instances—probably not too expensive—then creates a merged RunList from them—again OK, as this is lazy—then calls the node(Node) filter. The filter is incremental, but if most builds were not on this computer, it would load many more than the limit of 50 in t:buildListTable before it finds some to display.

      Trimming the merged list before filtering would solve that problem (making this perform much like View/builds.jelly), but then you might not see anywhere near 50 builds, or indeed any at all, even when there are some (older) builds run on this computer.

      User/builds.jelly calls User.getBuilds which does not even bother using an incremental filter. It does use newBuilds to limit how many builds are considered per job, but then scans all of those at once for mentions of the current user.

      Ideally all such displays would show all applicable builds, but use ProgressiveRendering so that build records are only loaded in a background thread and only so long as you keep the page open. (Compare AsynchPeople.)

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-22008 buildTimeTrend only shows the last 20 builds

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18065 AbstractLazyLoadRunMap.iterator() calls .all()

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21437 Failed to update /computer/xxxxxxxxxxx/builds

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21159 buildTimeTrend only shows last day of builds

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-18992 rssChangeLog should be limited

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23945 Test result trend breaks lazy-loading

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            View 14 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/User.java
            http://jenkins-ci.org/commit/jenkins/46d4a638182d149b105414eadf172157e4fcb96e
            Log:
            JENKINS-20892 /user//rssLatest should use getAllItems to check in folders, just like /user//builds does.
            (cherry picked from commit ece93739dd291d03c673664afe6b4aaa00f07ef1)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/User.java http://jenkins-ci.org/commit/jenkins/46d4a638182d149b105414eadf172157e4fcb96e Log: JENKINS-20892 /user/ /rssLatest should use getAllItems to check in folders, just like /user/ /builds does. (cherry picked from commit ece93739dd291d03c673664afe6b4aaa00f07ef1)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/User.java
            http://jenkins-ci.org/commit/jenkins/915000b5a0a4c33e02104e47c4b9420192531e07
            Log:
            JENKINS-20892 Introduced method so that /user//rssLatest can check UserIdCause just like /user//builds already was.
            (cherry picked from commit 76af02eed23f43ebd7fde094d939339705b1ef0f)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/User.java http://jenkins-ci.org/commit/jenkins/915000b5a0a4c33e02104e47c4b9420192531e07 Log: JENKINS-20892 Introduced method so that /user/ /rssLatest can check UserIdCause just like /user/ /builds already was. (cherry picked from commit 76af02eed23f43ebd7fde094d939339705b1ef0f)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/Functions.java
            core/src/main/java/hudson/model/BuildTimelineWidget.java
            core/src/main/java/hudson/model/Job.java
            core/src/main/java/hudson/model/User.java
            core/src/main/java/hudson/util/RunList.java
            core/src/main/java/jenkins/widgets/BuildListTable.java
            core/src/main/resources/hudson/model/BuildTimelineWidget/control.jelly
            core/src/main/resources/hudson/model/Job/buildTimeTrend.jelly
            core/src/main/resources/hudson/model/User/builds.jelly
            core/src/main/resources/lib/hudson/buildListTable.jelly
            http://jenkins-ci.org/commit/jenkins/ef6343be19fc990e0fcdab31d4d3f30c56baba0b
            Log:
            JENKINS-20892 Partial fix of poor scalability in /builds and related displays.
            (cherry picked from commit c5e23739fa85a6fe93ad90a35da4051a2767c874)

            Compare: https://github.com/jenkinsci/jenkins/compare/f61086b56cec...ef6343be19fc

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/Functions.java core/src/main/java/hudson/model/BuildTimelineWidget.java core/src/main/java/hudson/model/Job.java core/src/main/java/hudson/model/User.java core/src/main/java/hudson/util/RunList.java core/src/main/java/jenkins/widgets/BuildListTable.java core/src/main/resources/hudson/model/BuildTimelineWidget/control.jelly core/src/main/resources/hudson/model/Job/buildTimeTrend.jelly core/src/main/resources/hudson/model/User/builds.jelly core/src/main/resources/lib/hudson/buildListTable.jelly http://jenkins-ci.org/commit/jenkins/ef6343be19fc990e0fcdab31d4d3f30c56baba0b Log: JENKINS-20892 Partial fix of poor scalability in /builds and related displays. (cherry picked from commit c5e23739fa85a6fe93ad90a35da4051a2767c874) Compare: https://github.com/jenkinsci/jenkins/compare/f61086b56cec...ef6343be19fc
            domi Dominik Bartholdi added a comment -

            with this fix/change, only 20 builds are shown in the buildTimeTrend - see JENKINS-22008 for more about it.

            domi Dominik Bartholdi added a comment - with this fix/change, only 20 builds are shown in the buildTimeTrend - see JENKINS-22008 for more about it.
            samxiao Sam Xiao added a comment -

            Can we port this back to LTS?

            samxiao Sam Xiao added a comment - Can we port this back to LTS?

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: