Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19310

Incorrect links in build history when view is defined inside a folder

      Create a "Foo" folder and job "Bar" inside it
      check the build history for the default 'All' view
      links for builds are JENKINS/job/Foo/view/All/job/Foo/job/Bar, should be
      JENKINS/job/Foo/view/All/job/Bar

          [JENKINS-19310] Incorrect links in build history when view is defined inside a folder

          Nicolas De Loof created issue -

          Nicolas De Loof added a comment - see https://github.com/jenkinsci/jenkins/pull/913
          Daniel Beck made changes -
          Labels Original: folders New: folders lts-candidate
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-20004 [ JENKINS-20004 ]

          Jesse Glick added a comment -

          jobBaseURL is just too fragile and probably needs to go away. BuildListTable should instead produce absolute URLs. It could be given a View ancestor so that it could check whether a job is a member of the given view, and if so, link to it via that view.

          Jesse Glick added a comment - jobBaseURL is just too fragile and probably needs to go away. BuildListTable should instead produce absolute URLs. It could be given a View ancestor so that it could check whether a job is a member of the given view, and if so, link to it via that view.
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/ListView.java
          core/src/main/resources/hudson/model/View/builds.jelly
          test/src/test/java/jenkins/widgets/BuildListTableTest.java
          http://jenkins-ci.org/commit/jenkins/00ab6012b8607b5290aa0bf88fc2f55c5cd36caa
          Log:
          JENKINS-19310 Reproduced problem in test.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/ListView.java core/src/main/resources/hudson/model/View/builds.jelly test/src/test/java/jenkins/widgets/BuildListTableTest.java http://jenkins-ci.org/commit/jenkins/00ab6012b8607b5290aa0bf88fc2f55c5cd36caa Log: JENKINS-19310 Reproduced problem in test.

          Jesse Glick added a comment -

          Could fix use of jobBaseUrl in projectView.jelly and various column.jelly, but those are not used here anyway.

          Jesse Glick added a comment - Could fix use of jobBaseUrl in projectView.jelly and various column.jelly , but those are not used here anyway.

          Jesse Glick added a comment -

          Fix is too risky to be an LTS candidate.

          Jesse Glick added a comment - Fix is too risky to be an LTS candidate.
          Jesse Glick made changes -
          Labels Original: folders lts-candidate New: folders

            jglick Jesse Glick
            ndeloof Nicolas De Loof
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: