Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20052

ListView.getItems makes too many passes through jobs list

    • Jenkins 2.239

      Since pull 757 in 1.512, ListView can include items in subfolders. Unfortunately it seems that getItems calls ViewJobFilter with anomalous arguments: items may be a superset, rather than a subset, of allItems.

      Should be better tested, and simplified by inlining the includeItems method, which could also improve performance by removing the double traversal of the job hierarchy (which checks ACLs each time through).

          [JENKINS-20052] ListView.getItems makes too many passes through jobs list

          Jesse Glick created issue -
          Jesse Glick made changes -
          Assignee Original: Jacob Robertson [ jacob_robertson ] New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Link New: This issue depends on JENKINS-18721 [ JENKINS-18721 ]
          Daniel Beck made changes -
          Labels Original: folders performance New: folders lts-candidate performance
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-20143 [ JENKINS-20143 ]
          Georg Sash made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Georg Sash made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Jesse Glick made changes -
          Link New: This issue depends on JENKINS-20143 [ JENKINS-20143 ]
          Jesse Glick made changes -
          Link Original: This issue is duplicated by JENKINS-20143 [ JENKINS-20143 ]
          Jesse Glick made changes -
          Labels Original: folders lts-candidate performance New: folders performance
          Summary Original: ListView.getItems behaves oddly when including items from folders New: ListView.getItems makes too many passes through jobs list
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-18364 [ JENKINS-18364 ]

            raihaan Raihaan Shouhell
            jglick Jesse Glick
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: