Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20085

Functions.globalIota overflow

    XMLWordPrintable

Details

    Description

      A user with a long-running Jenkins instance reported that Build Now sidepanel links stopped working. Turns out the JavaScript contained functions like build_id-2348648747 which are not syntactically valid identifiers, resulting in JS errors. Problem seems to have been an integer overflow in Functions.globalIota; worked around without restart by using script console to run Functions.globalIota = 0.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19368 "You must use POST method to trigger builds" from Context Menu

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19333 After a given uptime of Jenkins, build now link doesn't work as expected

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20777 Build now link brings up "you must use POST method to trigger builds."

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/Functions.java
            http://jenkins-ci.org/commit/jenkins/587c6fe317bfe3560069ceb41495c6f5f5d114d1
            Log:
            [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/Functions.java http://jenkins-ci.org/commit/jenkins/587c6fe317bfe3560069ceb41495c6f5f5d114d1 Log: [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2954
            [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (Revision 587c6fe317bfe3560069ceb41495c6f5f5d114d1)

            Result = UNSTABLE
            Jesse Glick : 587c6fe317bfe3560069ceb41495c6f5f5d114d1
            Files :

            • core/src/main/java/hudson/Functions.java
            • changelog.html
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2954 [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (Revision 587c6fe317bfe3560069ceb41495c6f5f5d114d1) Result = UNSTABLE Jesse Glick : 587c6fe317bfe3560069ceb41495c6f5f5d114d1 Files : core/src/main/java/hudson/Functions.java changelog.html
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/Functions.java
            http://jenkins-ci.org/commit/jenkins/3859b831464e56ff478771481912a0010edee2b1
            Log:
            [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.

            (cherry picked from commit 587c6fe317bfe3560069ceb41495c6f5f5d114d1)

            Conflicts:
            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/Functions.java http://jenkins-ci.org/commit/jenkins/3859b831464e56ff478771481912a0010edee2b1 Log: [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (cherry picked from commit 587c6fe317bfe3560069ceb41495c6f5f5d114d1) Conflicts: changelog.html
            mmlegra Matt Legrand added a comment -

            A side note: the Script Console fix mentioned above worked nicely for me on Jenkins 1.528. The symptom was a page showing "You must fix POST method..." when starting any job. This started occurring for no obvious reason recently. After doing the fix above, Jenkins behaved correctly once more.

            mmlegra Matt Legrand added a comment - A side note: the Script Console fix mentioned above worked nicely for me on Jenkins 1.528. The symptom was a page showing "You must fix POST method..." when starting any job. This started occurring for no obvious reason recently. After doing the fix above, Jenkins behaved correctly once more.

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: