• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      A user with a long-running Jenkins instance reported that Build Now sidepanel links stopped working. Turns out the JavaScript contained functions like build_id-2348648747 which are not syntactically valid identifiers, resulting in JS errors. Problem seems to have been an integer overflow in Functions.globalIota; worked around without restart by using script console to run Functions.globalIota = 0.

          [JENKINS-20085] Functions.globalIota overflow

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/Functions.java
          http://jenkins-ci.org/commit/jenkins/587c6fe317bfe3560069ceb41495c6f5f5d114d1
          Log:
          [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/Functions.java http://jenkins-ci.org/commit/jenkins/587c6fe317bfe3560069ceb41495c6f5f5d114d1 Log: [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2954
          [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (Revision 587c6fe317bfe3560069ceb41495c6f5f5d114d1)

          Result = UNSTABLE
          Jesse Glick : 587c6fe317bfe3560069ceb41495c6f5f5d114d1
          Files :

          • core/src/main/java/hudson/Functions.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2954 [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (Revision 587c6fe317bfe3560069ceb41495c6f5f5d114d1) Result = UNSTABLE Jesse Glick : 587c6fe317bfe3560069ceb41495c6f5f5d114d1 Files : core/src/main/java/hudson/Functions.java changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/Functions.java
          http://jenkins-ci.org/commit/jenkins/3859b831464e56ff478771481912a0010edee2b1
          Log:
          [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong.

          (cherry picked from commit 587c6fe317bfe3560069ceb41495c6f5f5d114d1)

          Conflicts:
          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/Functions.java http://jenkins-ci.org/commit/jenkins/3859b831464e56ff478771481912a0010edee2b1 Log: [FIXED JENKINS-20085] Overflow in Jenkins.globalIota. Simpler and safer to use an AtomicLong. (cherry picked from commit 587c6fe317bfe3560069ceb41495c6f5f5d114d1) Conflicts: changelog.html

          Matt Legrand added a comment -

          A side note: the Script Console fix mentioned above worked nicely for me on Jenkins 1.528. The symptom was a page showing "You must fix POST method..." when starting any job. This started occurring for no obvious reason recently. After doing the fix above, Jenkins behaved correctly once more.

          Matt Legrand added a comment - A side note: the Script Console fix mentioned above worked nicely for me on Jenkins 1.528. The symptom was a page showing "You must fix POST method..." when starting any job. This started occurring for no obvious reason recently. After doing the fix above, Jenkins behaved correctly once more.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: