Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24380

Use build numbers as IDs

    XMLWordPrintable

Details

    Description

      Stop using the formatted timestamp to compute Run.id, and just use the build number as the directory name, so that

      r.getId().equals(String.valueOf(r.number))

      in which case the timestamp would have to be made a nontransient field (but number could be transient). Then build number symlinks could be dispensed with, saving some hassle and overhead; and AbstractLazyLoadRunMap could be greatly simplified, since the disk location would be immediately predictable from the number, which is what most API calls care about.

      The downside is that there would have to be a one-time migration, which could be slow on a big installation, and not reversible.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26575 Running the reverse migrator after upgrading to 1.597 throws NoClassDefFoundError: javax/servlet/http/HttpServletRequest

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26743 Build record migration prints warnings for permalinks

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27531 Stack overflow in WorkflowRun.reload after run ID migration

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26690 Build stats throws illegal argument exception on dashboard view

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27055 Slave To Master Access Control needs updating for JENKINS_HOME layout change

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-29989 RunIdMigrator fails to revert Matrix and Maven jobs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26739 ISE from AbstractLazyLoadRunMap.proposeNewNumber for concurrent matrix builds

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26582 ISE from RunMap.put using /git/notifyCommit on a matrix project

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28865 java.lang.IllegalStateException: while using using /git/notifyCommit in Freestyle project

          • Major - Major loss of function.
          • Closed
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25340 lost trend history after skipping build

          • Major - Major loss of function.
          • Reopened
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19977 Build records get confused by timezone changes

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-22767 AbstractLazyLoadRunMap.getById subject to race condition with .load

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23130 nextBuildNumber keeps being set to previous numbers

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23152 builds getting lost due to GerritTrigger

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-24376 Queue constantly locked when rapidly scheduling builds

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-29011 Jenkins 1.609.1 reverse migration script doesn't work when using a custom log folder

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26519 Build records not migrated due to “failed to rename” on Windows

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26496 Trying to get the DateFormat as build ID

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26624 Content of BUILD_ID environment variable changed from timestamp to build number

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26626 Zentimestamp plugin no longer compatible with Jenkins 1.597

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26520 Environment Variables BUILD_ID and BUILD_NUMBER now return the same value

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link PR 1379

          Web Link Wiki page about the migration

          Activity

            Ascending order - Click to sort in descending order
            View 19 older comments
            jglick Jesse Glick added a comment -

            The Disk Usage plugin issue is already filed in JENKINS-26496; disable that plugin until its maintainer merges my PR, unless you want to run a snapshot build.

            The NPE from unmigrateJobsDir I have not seen. Apparently there is a file f for which f.isDirectory() && f.listFiles() == null, which seems anomalous (usually null from listFiles means the directory does not really exist), but prior to Java 7 there is no way to get a detailed exception from a file listing so I can only speculate about what that might have been. Anyway I can make that code more robust in 1.599.

            jglick Jesse Glick added a comment - The Disk Usage plugin issue is already filed in JENKINS-26496 ; disable that plugin until its maintainer merges my PR, unless you want to run a snapshot build. The NPE from unmigrateJobsDir I have not seen. Apparently there is a file f for which f.isDirectory() && f.listFiles() == null , which seems anomalous (usually null from listFiles means the directory does not really exist), but prior to Java 7 there is no way to get a detailed exception from a file listing so I can only speculate about what that might have been. Anyway I can make that code more robust in 1.599.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/plugins/disk_usage/BuildDiskUsageAction.java
            src/main/java/hudson/plugins/disk_usage/DiskUsageBuildInformation.java
            src/main/java/hudson/plugins/disk_usage/DiskUsageUtil.java
            src/main/java/hudson/plugins/disk_usage/ProjectDiskUsage.java
            src/main/java/hudson/plugins/disk_usage/ProjectDiskUsageAction.java
            http://jenkins-ci.org/commit/disk-usage-plugin/19e500d2a168a1dfedf8987c618b4a4d0c9be8a0
            Log:
            JENKINS-24380 Stop relying on the format of Run.id.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/disk_usage/BuildDiskUsageAction.java src/main/java/hudson/plugins/disk_usage/DiskUsageBuildInformation.java src/main/java/hudson/plugins/disk_usage/DiskUsageUtil.java src/main/java/hudson/plugins/disk_usage/ProjectDiskUsage.java src/main/java/hudson/plugins/disk_usage/ProjectDiskUsageAction.java http://jenkins-ci.org/commit/disk-usage-plugin/19e500d2a168a1dfedf8987c618b4a4d0c9be8a0 Log: JENKINS-24380 Stop relying on the format of Run.id.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/hudson/plugins/disk_usage/BuildDiskUsageAction.java
            src/main/java/hudson/plugins/disk_usage/DiskUsageBuildInformation.java
            src/main/java/hudson/plugins/disk_usage/DiskUsageUtil.java
            src/main/java/hudson/plugins/disk_usage/ProjectDiskUsage.java
            src/main/java/hudson/plugins/disk_usage/ProjectDiskUsageAction.java
            http://jenkins-ci.org/commit/disk-usage-plugin/e1555569bfb43cde12816de9abe08039ea043e48
            Log:
            Merge pull request #26 from jglick/build-number-is-id-JENKINS-24380

            JENKINS-24380 Stop relying on the format of Run.id

            Compare: https://github.com/jenkinsci/disk-usage-plugin/compare/f9c0ef96b19a...e1555569bfb4

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/disk_usage/BuildDiskUsageAction.java src/main/java/hudson/plugins/disk_usage/DiskUsageBuildInformation.java src/main/java/hudson/plugins/disk_usage/DiskUsageUtil.java src/main/java/hudson/plugins/disk_usage/ProjectDiskUsage.java src/main/java/hudson/plugins/disk_usage/ProjectDiskUsageAction.java http://jenkins-ci.org/commit/disk-usage-plugin/e1555569bfb43cde12816de9abe08039ea043e48 Log: Merge pull request #26 from jglick/build-number-is-id- JENKINS-24380 JENKINS-24380 Stop relying on the format of Run.id Compare: https://github.com/jenkinsci/disk-usage-plugin/compare/f9c0ef96b19a...e1555569bfb4
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/plugins/build_publisher/ExternalProjectProperty.java
            src/main/java/hudson/plugins/build_publisher/HTTPBuildTransmitter.java
            http://jenkins-ci.org/commit/build-publisher-plugin/9a44c001e80cb5575aae92db53642667fd419e6c
            Log:
            JENKINS-24380 Stop relying on the format of Run.id.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/build_publisher/ExternalProjectProperty.java src/main/java/hudson/plugins/build_publisher/HTTPBuildTransmitter.java http://jenkins-ci.org/commit/build-publisher-plugin/9a44c001e80cb5575aae92db53642667fd419e6c Log: JENKINS-24380 Stop relying on the format of Run.id.
            ydubreuil Yoann Dubreuil added a comment -

            Adding link to wiki

            ydubreuil Yoann Dubreuil added a comment - Adding link to wiki

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: