Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24589

Build History - name and links overlap if build names are long

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Server: Jenkins v1.576, 'build name setter' plugin v1.3
      Viewed On: Windows 7 SP1 x64, Chrome Version 36.0.1985.143 m

      The build names overlap the build links when the build names are long, using the 'build-name-setter' plugin.

          [JENKINS-24589] Build History - name and links overlap if build names are long

          Daniel Beck added a comment -

          Some related discussion and suggestions at https://github.com/jenkinsci/jenkins/pull/1466

          Please consider commenting how/why/when a proposed solution would (not) work well. (Please limit your comments to constructive criticism.)

          I'll try to ask tfennelly in IRC about a short-term solution suitable for 1.580.x.

          Daniel Beck added a comment - Some related discussion and suggestions at https://github.com/jenkinsci/jenkins/pull/1466 Please consider commenting how/why/when a proposed solution would (not) work well. (Please limit your comments to constructive criticism.) I'll try to ask tfennelly in IRC about a short-term solution suitable for 1.580.x.

          Tom FENNELLY added a comment -

          Please see https://github.com/jenkinsci/jenkins/pull/1470. Try it if you can and provide feedback.

          Tom FENNELLY added a comment - Please see https://github.com/jenkinsci/jenkins/pull/1470 . Try it if you can and provide feedback.

          I implemented the war file from pull 1470 and it did clean it up a bit. The text no longer overlaps and is easier to read. Thank you!

          Micheal Schexnayder added a comment - I implemented the war file from pull 1470 and it did clean it up a bit. The text no longer overlaps and is easier to read. Thank you!

          Tom FENNELLY added a comment -

          @Michael thanks for trying PR #1470. Sounds as though it did not clean it up quite to your satisfaction though, right?

          Tom FENNELLY added a comment - @Michael thanks for trying PR #1470. Sounds as though it did not clean it up quite to your satisfaction though, right?

          Tom FENNELLY added a comment -

          Fixed in cb9036c45527223525cc1b48020a8ed777020c1a

          Tom FENNELLY added a comment - Fixed in cb9036c45527223525cc1b48020a8ed777020c1a

          Daniel Beck added a comment - - edited

          IMO this should be removed from .3. It is not suitable for LTS, as it appears to break HTML descriptions (JENKINS-26406) and has a performance regression when revealing a few hundred builds by clicking 'more' (JENKINS-26445). It's also no longer possible to click the ball to go to the build output page.

          A post on the dev list seems to indicate that .3 introduced an issue that may be JENKINS-25971, whose fix (it's actually fixed) caused a few more regressions (JENKINS-26312 JENKINS-26298 JENKINS-26306 I think) that were finally fixed in 1.596 or so.

          Daniel Beck added a comment - - edited IMO this should be removed from .3. It is not suitable for LTS, as it appears to break HTML descriptions ( JENKINS-26406 ) and has a performance regression when revealing a few hundred builds by clicking 'more' ( JENKINS-26445 ). It's also no longer possible to click the ball to go to the build output page. A post on the dev list seems to indicate that .3 introduced an issue that may be JENKINS-25971 , whose fix (it's actually fixed) caused a few more regressions ( JENKINS-26312 JENKINS-26298 JENKINS-26306 I think) that were finally fixed in 1.596 or so.

          Tom FENNELLY added a comment -

          @Daniel sorry, what exactly do you mean when you say ".3" ?

          I'd prefer to try fix these issues (when I get a chance) Vs going back to the way it was before, with labels etc overlapping.

          Tom FENNELLY added a comment - @Daniel sorry, what exactly do you mean when you say ".3" ? I'd prefer to try fix these issues (when I get a chance) Vs going back to the way it was before, with labels etc overlapping.

          Tom FENNELLY added a comment -

          Ah ... you mean 1.580.3 I think.

          Tom FENNELLY added a comment - Ah ... you mean 1.580.3 I think.

          Steve Haworth added a comment -

          I would check the conclusions Daniel has come to carefully, I think I have both the issues he indicates.
          However, they only seemed to be present for me when upgrading to 1.586.
          This change may not have introduced these issues.
          The improvement with non-overlapping, I would not like to see regressed.

          Steve Haworth added a comment - I would check the conclusions Daniel has come to carefully, I think I have both the issues he indicates. However, they only seemed to be present for me when upgrading to 1.586. This change may not have introduced these issues. The improvement with non-overlapping, I would not like to see regressed.

          Daniel Beck added a comment - - edited

          The recent discussion is about backporting this change to the LTS release 1.580.3 only (which has been rejected due to the regressions this causes). It has nothing to do with the weekly releases which will continue to include this new build history.

          I admit my comment wasn't too clear when only viewing comments to this issue, as there has been no discussion about LTS inclusion, only changes to the issue tags indicated that.

          Daniel Beck added a comment - - edited The recent discussion is about backporting this change to the LTS release 1.580.3 only (which has been rejected due to the regressions this causes). It has nothing to do with the weekly releases which will continue to include this new build history. I admit my comment wasn't too clear when only viewing comments to this issue, as there has been no discussion about LTS inclusion, only changes to the issue tags indicated that.

            Unassigned Unassigned
            jstrouse Joshua Strouse
            Votes:
            9 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved: