• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline

      This may be something that I've missed but how are you planing on adding support to add build wrappers to the Workflow plugin. We depend a lot on a few plugins to modify the console output to for example color code, find match patterns and to filter out password.

          [JENKINS-24673] SimpleBuildWrapper

          Marcus Jacobsson created issue -
          Jesse Glick made changes -
          Remote Link New: This issue links to "Trello (Web Link)" [ 11900 ]
          Jesse Glick made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: Jesse Glick [ jglick ]

          Jesse Glick added a comment -

          Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild) where Environment is considered Serializable, and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc.

          The tool-env plugin does not need this, due to the standard tool step.

          Jesse Glick added a comment - Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild ) where Environment is considered Serializable , and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc. The tool-env plugin does not need this, due to the standard tool step.
          Jesse Glick made changes -
          Remote Link Original: This issue links to "Trello (Web Link)" [ 11900 ]
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-26051 [ JENKINS-26051 ]
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-26339 [ JENKINS-26339 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Jesse Glick added a comment -

          Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development.

          Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.

          Jesse Glick added a comment - Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development. Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins PR 1530 (Web Link)" [ 12018 ]

            jglick Jesse Glick
            hanabishi Marcus Jacobsson
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: