[JENKINS-32067] Use ACE editor annotations to show Groovy syntax errors

Type: Improvement
Resolution: Fixed
Priority: Major
Component/s: pipeline
Labels:
- ux

Similar Issues:
Powered by SuggestiMate

Show

A regular stapler validation message is currently shown for Groovy syntax validation messages.
Since this validation messages are linked to source lines, it could take advantage of ACE editor annotation API to show this messages behind the affected line.

editor.getSession().setAnnotations([{
  row: 1,
  column: 10,
  text: "Error message"
  type: "error" // also warning and information if needed
}]);

row, column and text can be retrieved from the current error message, but for better design CpsFlowDefinition.DescriptorImpl.doCheckScript should be modified to return a JSON containing this data.

depends on

JENKINS-32819 Pipeline compilation error detection broken when using CSRF detection

Resolved

is related to

JENKINS-31909 Groovy script syntax validation not working as expected

Resolved

links to

PR 281

Antonio Muñiz added a comment - 2015-12-15 11:14

This is a replacement of the message shown in ~~JENKINS-31909~~

Antonio Muñiz added a comment - 2015-12-15 11:14 This is a replacement of the message shown in JENKINS-31909

SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Code changed in jenkins
User: Antonio Muñiz
Path:
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-plugin/31e5a8f86cd9f8a5d28d422b4a07d5f946990ce9
Log:
~~JENKINS-32067~~ Show groovy syntax errors as ACE editor annotations

SCM/JIRA link daemon added a comment - 2016-01-12 15:24 Code changed in jenkins User: Antonio Muñiz Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-plugin/31e5a8f86cd9f8a5d28d422b4a07d5f946990ce9 Log: JENKINS-32067 Show groovy syntax errors as ACE editor annotations

SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Code changed in jenkins
User: Antonio Muñiz
Path:
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-plugin/b25e5faea702549d7333d01f2aa9230ad2920e11
Log:
~~JENKINS-32067~~ Manage script approval messages

SCM/JIRA link daemon added a comment - 2016-01-12 15:24 Code changed in jenkins User: Antonio Muñiz Path: cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-plugin/b25e5faea702549d7333d01f2aa9230ad2920e11 Log: JENKINS-32067 Manage script approval messages

SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Code changed in jenkins
User: Antonio Muñiz
Path:
CHANGES.md
COMPATIBILITY.md
README.md
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsScmFlowDefinitionTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DSLTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/EnvWorkflowTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunRestartTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDumpTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/global/WorkflowLibRepositoryTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/RestartingLoadStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/DeleteDirStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EnvStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/IsUnixStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/MailStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PwdStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ReadWriteFileStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SynchronousNonBlockingStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepRestartTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/durable_task/ShellStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/GitStepRestartTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/GitStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/MercurialStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/stash/StashTest.java
api/src/main/java/org/jenkinsci/plugins/workflow/pickles/Pickle.java
cps/package.json
cps/pom.xml
cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
cps/src/test/java/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.java
job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
pom.xml
support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/ExecutorPickle.java
support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/TryRepeatedly.java
support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
http://jenkins-ci.org/commit/workflow-plugin/bb348cfd84e5f379043d15fbff77f76286644c73
Log:
Merge branch 'master' into ~~JENKINS-32067~~

SCM/JIRA link daemon added a comment - 2016-01-12 15:24 Code changed in jenkins User: Antonio Muñiz Path: CHANGES.md COMPATIBILITY.md README.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsScmFlowDefinitionTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/DSLTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/EnvWorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunRestartTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDumpTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/global/WorkflowLibRepositoryTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/RestartingLoadStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/DeleteDirStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EnvStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/IsUnixStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/MailStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PwdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ReadWriteFileStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SynchronousNonBlockingStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepRestartTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/durable_task/ShellStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/GitStepRestartTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/GitStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/MercurialStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/stash/StashTest.java api/src/main/java/org/jenkinsci/plugins/workflow/pickles/Pickle.java cps/package.json cps/pom.xml cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly cps/src/test/java/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java pom.xml support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/ExecutorPickle.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/TryRepeatedly.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/bb348cfd84e5f379043d15fbff77f76286644c73 Log: Merge branch 'master' into JENKINS-32067

SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Code changed in jenkins
User: Jesse Glick
Path:
CHANGES.md
cps-global-lib/src/test/java/org/jenkinsci/plugins/workflow/cps/global/WorkflowLibRepositoryLocalTest.java
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-plugin/6345d4732f44a37f2a59d3862131c3493682cd99
Log:
[FIXED JENKINS-32067] Noting merge of #281.

Compare: https://github.com/jenkinsci/workflow-plugin/compare/8d56e60f6445...6345d4732f44

SCM/JIRA link daemon added a comment - 2016-01-12 15:24 Code changed in jenkins User: Jesse Glick Path: CHANGES.md cps-global-lib/src/test/java/org/jenkinsci/plugins/workflow/cps/global/WorkflowLibRepositoryLocalTest.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-plugin/6345d4732f44a37f2a59d3862131c3493682cd99 Log: [FIXED JENKINS-32067] Noting merge of #281. Compare: https://github.com/jenkinsci/workflow-plugin/compare/8d56e60f6445...6345d4732f44

SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Code changed in jenkins
User: Antonio Muñiz
Path:
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-cps-plugin/b6c25f99d6866364f5e0a570e14394f318ea025f
Log:
~~JENKINS-32067~~ Show groovy syntax errors as ACE editor annotations

Originally-Committed-As: 31e5a8f86cd9f8a5d28d422b4a07d5f946990ce9

SCM/JIRA link daemon added a comment - 2016-04-05 20:31 Code changed in jenkins User: Antonio Muñiz Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-cps-plugin/b6c25f99d6866364f5e0a570e14394f318ea025f Log: JENKINS-32067 Show groovy syntax errors as ACE editor annotations Originally-Committed-As: 31e5a8f86cd9f8a5d28d422b4a07d5f946990ce9

SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Code changed in jenkins
User: Antonio Muñiz
Path:
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-cps-plugin/dc4f5d8eb4013f57cd0fa2021d2bf25e959a95e8
Log:
~~JENKINS-32067~~ Manage script approval messages

Originally-Committed-As: b25e5faea702549d7333d01f2aa9230ad2920e11

SCM/JIRA link daemon added a comment - 2016-04-05 20:31 Code changed in jenkins User: Antonio Muñiz Path: cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-cps-plugin/dc4f5d8eb4013f57cd0fa2021d2bf25e959a95e8 Log: JENKINS-32067 Manage script approval messages Originally-Committed-As: b25e5faea702549d7333d01f2aa9230ad2920e11

SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Code changed in jenkins
User: Antonio Muñiz
Path:
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsScmFlowDefinitionTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DSLTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDumpTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/RestartingLoadStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/IsUnixStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PwdStepTest.java
cps/package.json
cps/pom.xml
cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
cps/src/test/java/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.java
http://jenkins-ci.org/commit/workflow-cps-plugin/4a097317efb158a6e92225125e29bb2c354b7bf3
Log:
Merge branch 'master' into ~~JENKINS-32067~~

Originally-Committed-As: bb348cfd84e5f379043d15fbff77f76286644c73

SCM/JIRA link daemon added a comment - 2016-04-05 20:31 Code changed in jenkins User: Antonio Muñiz Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsScmFlowDefinitionTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/DSLTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDumpTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/cps/steps/RestartingLoadStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/IsUnixStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PwdStepTest.java cps/package.json cps/pom.xml cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly cps/src/test/java/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/4a097317efb158a6e92225125e29bb2c354b7bf3 Log: Merge branch 'master' into JENKINS-32067 Originally-Committed-As: bb348cfd84e5f379043d15fbff77f76286644c73

SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Code changed in jenkins
User: Jesse Glick
Path:
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java
cps/src/main/js/workflow-editor.js
http://jenkins-ci.org/commit/workflow-cps-plugin/cdfde8c3c789eda2e6019249d68f7112f0fc8ee1
Log:
[FIXED JENKINS-32067] Noting merge of #281.

Originally-Committed-As: 6345d4732f44a37f2a59d3862131c3493682cd99

SCM/JIRA link daemon added a comment - 2016-04-05 20:31 Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionValidator.java cps/src/main/js/workflow-editor.js http://jenkins-ci.org/commit/workflow-cps-plugin/cdfde8c3c789eda2e6019249d68f7112f0fc8ee1 Log: [FIXED JENKINS-32067] Noting merge of #281. Originally-Committed-As: 6345d4732f44a37f2a59d3862131c3493682cd99

Assignee:: Antonio Muñiz

Reporter:: Antonio Muñiz

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2015-12-14 22:45

Updated:: 2016-08-26 21:55

Resolved:: 2016-01-12 15:24

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Antonio Muñiz added a comment - 2015-12-15 11:14

Expand comment: Antonio Muñiz added a comment - 2015-12-15 11:14

Collapse comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Expand comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Collapse comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Expand comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Collapse comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Expand comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Collapse comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Expand comment: SCM/JIRA link daemon added a comment - 2016-01-12 15:24

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-05 20:31

People

Dates