Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36160

Credentials defined in the folder should be available to the folder

XMLWordPrintable

      getCredentials(Class,Item,Authentication,List) has not been overridden so the default behaviour of redirecting to Item.getParent() means that the folder's own credentials are not available to the folder itself.

      This was an oversight in the implementation of the CredentialsProvider contract for folders.

          [JENKINS-36160] Credentials defined in the folder should be available to the folder

          Jesse Glick added a comment -

          amuniz stephenconnolly did this fix the issue that the Add dropdown in, say, http://jenkins/job/some-multibranch/pipeline-syntax/ with, say, the git step selected, offered only Jenkins and not the (computed) folder itself?

          Jesse Glick added a comment - amuniz stephenconnolly did this fix the issue that the Add dropdown in, say, http ://jenkins/job/some-multibranch/pipeline-syntax/ with, say, the git step selected, offered only Jenkins and not the (computed) folder itself?

          Antonio Muñiz added a comment - - edited

          jglick I don't think so, this is about the list of credentials shown in the credentials select dropdown, not the Add dropdown.

          Antonio Muñiz added a comment - - edited jglick I don't think so, this is about the list of credentials shown in the credentials select dropdown, not the Add dropdown.

          Stephen Connolly added a comment -

          jglick nope that pipeline issue was the loss of it this was about some calls to lookupCredentials coming from the type `Item` and others coming from the type `ItemGroup` and the behaviour being inconsistent which lead to credentials in an Item that is also an ItemGroup (i.e. a Folder) not always being discoverable from the item itself (on code paths that treat the folder as an `Item`)

          Stephen Connolly added a comment - jglick nope that pipeline issue was the loss of it this was about some calls to lookupCredentials coming from the type `Item` and others coming from the type `ItemGroup` and the behaviour being inconsistent which lead to credentials in an Item that is also an ItemGroup (i.e. a Folder) not always being discoverable from the item itself (on code paths that treat the folder as an `Item`)

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: