Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36660

Acceptance tests for nested project and funky branch name regressions

    XMLWordPrintable

Details

    • 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-1

    Description

      We need to cover some of the recent regressions involving jobs nested in folders or branch names that were not properly URI encoded.

      See the following issues:

      Other issues that would benefit from this:

      Possibly JENKINS-36618 too, although we do have a good unit test for that one.

      Plan to cover them:

      • Ensure that a top-level project and nested project are created with the same name; assert that pipelines view shows the correct number of items (JENKINS-36618).
      • Ensure a nested multi-branch project is added that has branches with non-standard names. Navigate to run detail for "funky branch name" via Branches tab (JENKINS-36616)
      • Ensure we can kick off a run for the above project (JENKINS-36615)
      • Ensure the logs render for the above project (JENKINS-36613)
      • Ensure the test results render for the above project (obviously, the project needs to actually render test results. JDL is a good candidate for this now) (JENKINS-36674)
      • Ensure navigating directly to a run for the above project then closing the modal navigates back to the activity screen (JENKINS-36619)

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          View 26 older comments
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          package.json
          src/main/js/api/git.js
          src/test/js/edgeCases/folder.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/12a09175e215ee8ff81e48e73f89cbbfc942bc39
          Log:
          JENKINS-36660 using async series to make sure the changeset has passed before doing next step

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: package.json src/main/js/api/git.js src/test/js/edgeCases/folder.js http://jenkins-ci.org/commit/blueocean-acceptance-test/12a09175e215ee8ff81e48e73f89cbbfc942bc39 Log: JENKINS-36660 using async series to make sure the changeset has passed before doing next step
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/test/js/queued.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/9931413d544dc9e9bcd109eef277e67c9f3936ca
          Log:
          JENKINS-36660 make sure we reset the executors

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/test/js/queued.js http://jenkins-ci.org/commit/blueocean-acceptance-test/9931413d544dc9e9bcd109eef277e67c9f3936ca Log: JENKINS-36660 make sure we reset the executors
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/test/js/queued.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/c244fdb6f4a32614d433f48cfd8c57b7b8a19e03
          Log:
          JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open,

          Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/12a09175e215...c244fdb6f4a3

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/test/js/queued.js http://jenkins-ci.org/commit/blueocean-acceptance-test/c244fdb6f4a32614d433f48cfd8c57b7b8a19e03 Log: JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open, Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/12a09175e215...c244fdb6f4a3
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          package.json
          src/main/js/api/git.js
          src/main/js/page_objects/blueocean/bluePipelineActivity.js
          src/main/js/page_objects/blueocean/bluePipelineBranch.js
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/main/js/page_objects/blueocean/bluePipelines.js
          src/main/js/page_objects/classic_jenkins/computer.js
          src/main/js/page_objects/classic_jenkins/folderCreate.js
          src/main/js/page_objects/classic_jenkins/jobUtils.js
          src/main/js/page_objects/classic_jenkins/multibranchCreate.js
          src/main/js/page_objects/classic_jenkins/pipeline.js
          src/main/js/util/url.js
          src/test/java/io/jenkins/blueocean/EdgeCasesTest.java
          src/test/java/io/jenkins/blueocean/QueuedTest.java
          src/test/js/edgeCases/folder.js
          src/test/js/log-karaoke/freestyle.js
          src/test/js/log-karaoke/noStages.js
          src/test/js/log-karaoke/stages.js
          src/test/js/queued.js
          src/test/js/smoke.js
          src/test/resources/multibranch_1/Jenkinsfile
          src/test/resources/multibranch_1/TEST-failure.TestThisWillFailAbunch.xml
          src/test/resources/multibranch_1/TEST-failure.TestThisWontFail.xml
          http://jenkins-ci.org/commit/blueocean-acceptance-test/ebad36c457146cba0fbf822875df39659e6520fc
          Log:
          [FIX JENKINS-36660] WIP Acceptance tests for nested project and funky branch name regressions (#26)

          • Added git api for creating local git repos for testing
          • stash
          • JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path.
          • JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed
          • JENKINS-36660 Extending multibranch AT implementing creation of job
          • JENKINS-36660 Add fixme note so tom knows where the problems lies
          • JENKINS-36660 first working version of creating multibranch in folders
          • JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT.
          • JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo.
          • JENKINS-36660 make sure we do not start without wait for finish
          • JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class
          • JENKINS-36660 Implement check for runButton and start working on queued state
          • JENKINS-36660 WIP queued state testing, infrastructure code to set executors
          • JENKINS-36660 using async series to make sure the changeset has passed before doing next step
          • JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open,
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: package.json src/main/js/api/git.js src/main/js/page_objects/blueocean/bluePipelineActivity.js src/main/js/page_objects/blueocean/bluePipelineBranch.js src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/main/js/page_objects/blueocean/bluePipelines.js src/main/js/page_objects/classic_jenkins/computer.js src/main/js/page_objects/classic_jenkins/folderCreate.js src/main/js/page_objects/classic_jenkins/jobUtils.js src/main/js/page_objects/classic_jenkins/multibranchCreate.js src/main/js/page_objects/classic_jenkins/pipeline.js src/main/js/util/url.js src/test/java/io/jenkins/blueocean/EdgeCasesTest.java src/test/java/io/jenkins/blueocean/QueuedTest.java src/test/js/edgeCases/folder.js src/test/js/log-karaoke/freestyle.js src/test/js/log-karaoke/noStages.js src/test/js/log-karaoke/stages.js src/test/js/queued.js src/test/js/smoke.js src/test/resources/multibranch_1/Jenkinsfile src/test/resources/multibranch_1/TEST-failure.TestThisWillFailAbunch.xml src/test/resources/multibranch_1/TEST-failure.TestThisWontFail.xml http://jenkins-ci.org/commit/blueocean-acceptance-test/ebad36c457146cba0fbf822875df39659e6520fc Log: [FIX JENKINS-36660] WIP Acceptance tests for nested project and funky branch name regressions (#26) Added git api for creating local git repos for testing stash JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path. JENKINS-36660 WIP remove obsolete variable JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed JENKINS-36660 Add tests for JENKINS-36618 JENKINS-36660 Extending multibranch AT implementing creation of job JENKINS-36660 Add fixme note so tom knows where the problems lies JENKINS-36660 first working version of creating multibranch in folders JENKINS-36660 fix class name JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT. JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo. JENKINS-36660 remove legacy folder JENKINS-36660 fix renamed methood JENKINS-36660 make sure we do not start without wait for finish JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class JENKINS-36660 Implement check for runButton and start working on queued state JENKINS-36660 WIP queued state testing, infrastructure code to set executors JENKINS-36660 Implement checks for queued jobs JENKINS-36660 using async series to make sure the changeset has passed before doing next step JENKINS-36660 make sure we reset the executors JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open,
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          package.json
          src/main/js/api/git.js
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/edgeCases/folder.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/b587c8baea42c97ae32e13fbc02662a3ab20bac7
          Log:
          FIX Jenkins-35847 (#28)

          • Added git api for creating local git repos for testing
          • stash
          • JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path.
          • JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed
          • JENKINS-36660 Extending multibranch AT implementing creation of job
          • JENKINS-36660 Add fixme note so tom knows where the problems lies
          • JENKINS-36660 first working version of creating multibranch in folders
          • JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT.
          • JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo.
          • JENKINS-36660 make sure we do not start without wait for finish
          • JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class
          • JENKINS-36660 Implement check for runButton and start working on queued state
          • JENKINS-36660 WIP queued state testing, infrastructure code to set executors
          • JENKINS-36660 using async series to make sure the changeset has passed before doing next step
          • JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open,
          • JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: package.json src/main/js/api/git.js src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/edgeCases/folder.js http://jenkins-ci.org/commit/blueocean-acceptance-test/b587c8baea42c97ae32e13fbc02662a3ab20bac7 Log: FIX Jenkins-35847 (#28) Added git api for creating local git repos for testing stash JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path. JENKINS-36660 WIP remove obsolete variable JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed JENKINS-36660 Add tests for JENKINS-36618 JENKINS-36660 Extending multibranch AT implementing creation of job JENKINS-36660 Add fixme note so tom knows where the problems lies JENKINS-36660 first working version of creating multibranch in folders JENKINS-36660 fix class name JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT. JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo. JENKINS-36660 remove legacy folder JENKINS-36660 fix renamed methood JENKINS-36660 make sure we do not start without wait for finish JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class JENKINS-36660 Implement check for runButton and start working on queued state JENKINS-36660 WIP queued state testing, infrastructure code to set executors JENKINS-36660 Implement checks for queued jobs JENKINS-36660 using async series to make sure the changeset has passed before doing next step JENKINS-36660 make sure we reset the executors JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open, JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors

          People

            tscherler Thorsten Scherler
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: