Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37324

We would like a more meaningful description of a step

    • frank, tethys, christmas, pannonian, iapetus, 1.0, Blue Ocean 1.0-rc3, Blue Ocean 1.0-rc4, Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta4, Blue Ocean 1.1, Blue Ocean 1.1

      Note: This has been implemented, but what is missing is some UI work to follow the design/limit wrapping on narrow screens (backend and pipeline components are completed, including api usage). 

       

      Scope

      • Pipeline API exposes step descriptions
      • Descriptions for steps reflected from the pipeline API
      • Update the UI of Blue Ocean to display the steps

      Design

      • Has Description
        • Description on left, black @ 100% opacity
          **Type to the right, with em dash, black @ 50% opacity (or grey color)
      • Has no Description
        • Type on left, black @ 100% opacity
      • Use Zeplin for extact metrics https://zpl.io/1MtiWN

      Mockup

      Notes
      We want to provide the developer a more meaningful description of the steps in Blue Ocean.

      For example, if we have a shell script being executed we'd like to provide the command as the description of that step. If we don't have that information, we'd like to fall back to a description of the step otherwise fall back to the step name.

        1. changes.png
          changes.png
          52 kB
        2. mockup.png
          mockup.png
          71 kB
        3.  #2 2017-06-05 10-50-45.png
          #2 2017-06-05 10-50-45.png
          87 kB

          [JENKINS-37324] We would like a more meaningful description of a step

          Andrea Knight added a comment -

          Stage is not  a reasonable solution.  We currently have 50+ shell scipts that we would eventually like to label.  Using Stage creates a very user-unfriendly stage view.   As mentioned above this issue is not tied directly to Blue Ocean, and I dont think it can be solved by stage view. For the short term, I think adding a label to 'sh' command, that is displayed in the pipeline view instead of "shell command" would be very helpful.  I know this has been mentioned before and closed as Not A Bug. 

          Andrea Knight added a comment - Stage is not  a reasonable solution.  We currently have 50+ shell scipts that we would eventually like to label.  Using Stage creates a very user-unfriendly stage view.   As mentioned above this issue is not tied directly to Blue Ocean, and I dont think it can be solved by stage view. For the short term, I think adding a label to 'sh' command, that is displayed in the pipeline view instead of "shell command" would be very helpful.  I know this has been mentioned before and closed as Not A Bug. 

          James Dumay added a comment -

          aknight1969 this ticket is almost done and you should get something that looks like the screenshot below - does that fit your use case? You would not have to use stage to provide the label.

          James Dumay added a comment - aknight1969 this ticket is almost done and you should get something that looks like the screenshot below - does that fit your use case? You would not have to use stage to provide the label.

          jamesdumay 

          This looks interesting but how you'll specify that "comment part". Will this be automatic? Or there will be new syntax i can put to name any step i do?

          mohamed badran added a comment - jamesdumay   This looks interesting but how you'll specify that "comment part". Will this be automatic? Or there will be new syntax i can put to name any step i do?

          Andrea Knight added a comment -

          jamesdumay  yes, that does look good, and would work for our needs in the Blue Ocean view, especially since it does not require stages.  Would the same labels also display in the Pipeline Steps view?

          Andrea Knight added a comment - jamesdumay   yes, that does look good, and would work for our needs in the Blue Ocean view, especially since it does not require stages.  Would the same labels also display in the Pipeline Steps view?

          Sam Van Oort added a comment -

          aknight1969 Sure would. I've got a beta out that offers a basic implementation of this, just fine-tuning some of the implementation details.

          Sam Van Oort added a comment - aknight1969 Sure would. I've got a beta out that offers a basic implementation of this, just fine-tuning some of the implementation details.

          Andrea Knight added a comment -

          svanoort Sounds great. We are looking forward to it! Thanks!

          Andrea Knight added a comment - svanoort Sounds great. We are looking forward to it! Thanks!

          Patrick Wolf added a comment -

          svanoort demonstrated the foundation for this work this morning:  

           

          https://www.youtube.com/watch?v=HhiUY70RVJY&t=510

          Patrick Wolf added a comment - svanoort demonstrated the foundation for this work this morning:     https://www.youtube.com/watch?v=HhiUY70RVJY&t=510

          Michael Neale added a comment -

          Just moving this blue ocean one to the top of the board so when the depenencies are available, the next free person can finish off the UI aspects (nearly there!)

          Michael Neale added a comment - Just moving this blue ocean one to the top of the board so when the depenencies are available, the next free person can finish off the UI aspects (nearly there!)

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/actions/ArgumentsAction.java
          src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/AbstractFlowScanner.java
          src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowTestUtils.java
          http://jenkins-ci.org/commit/workflow-api-plugin/6ee30a545ea341bf6d2710aaaea58397c63f740b
          Log:
          Merge pull request #26 from jenkinsci/step-action-jenkins-37324

          JENKINS-37324 Step action API

          Compare: https://github.com/jenkinsci/workflow-api-plugin/compare/03c18c83d083...6ee30a545ea3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/actions/ArgumentsAction.java src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/AbstractFlowScanner.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowTestUtils.java http://jenkins-ci.org/commit/workflow-api-plugin/6ee30a545ea341bf6d2710aaaea58397c63f740b Log: Merge pull request #26 from jenkinsci/step-action-jenkins-37324 JENKINS-37324 Step action API Compare: https://github.com/jenkinsci/workflow-api-plugin/compare/03c18c83d083...6ee30a545ea3

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/DSL.java
          src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
          src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/DSLTest.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/DescriptorMatchPredicate.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/MonomorphicStep.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/4d402bb2bf5828b141ed01c70c8dfcde59a9e9d1
          Log:
          Merge pull request #98 from jenkinsci/store-step-for-flownode-jenkins-37324

          JENKINS-37324 Store parameter info for steps as an action on the flownode

          Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/c6dfd2525f64...4d402bb2bf58

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/DSL.java src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep.java src/test/java/org/jenkinsci/plugins/workflow/cps/DSLTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/DescriptorMatchPredicate.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/MonomorphicStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/4d402bb2bf5828b141ed01c70c8dfcde59a9e9d1 Log: Merge pull request #98 from jenkinsci/store-step-for-flownode-jenkins-37324 JENKINS-37324 Store parameter info for steps as an action on the flownode Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/c6dfd2525f64...4d402bb2bf58

          Sam Van Oort added a comment -

          The backend parts are now fully live (all are in the update center). 

          Sam Van Oort added a comment - The backend parts are now fully live (all are in the update center). 

          James Dumay added a comment -

          This is great stuff mate

          James Dumay added a comment - This is great stuff mate

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          rest-api/pom.xml
          rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeExt.java
          rest-api/src/test/java/com/cloudbees/workflow/rest/endpoints/JobAndRunAPITest.java
          ui/pom.xml
          ui/src/main/js/view/templates/stage-logs.hbs
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/29b14fc6c51c2af58eb9c776a3fc3104ca171f4f
          Log:
          Merge pull request #39 from jenkinsci/step-descriptions-poc

          JENKINS-37324 Step descriptions proof of concept

          Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/2fbf4c02fea4...29b14fc6c51c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: rest-api/pom.xml rest-api/src/main/java/com/cloudbees/workflow/rest/external/FlowNodeExt.java rest-api/src/test/java/com/cloudbees/workflow/rest/endpoints/JobAndRunAPITest.java ui/pom.xml ui/src/main/js/view/templates/stage-logs.hbs http://jenkins-ci.org/commit/pipeline-stage-view-plugin/29b14fc6c51c2af58eb9c776a3fc3104ca171f4f Log: Merge pull request #39 from jenkinsci/step-descriptions-poc JENKINS-37324 Step descriptions proof of concept Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/2fbf4c02fea4...29b14fc6c51c

          Sam Van Oort added a comment -

          Stage View will have UI support for this once I cut the next release (the feature is merged in, I'm just waiting to cut a release until I can finish reviewing/testing the existing PRs). 

          Sam Van Oort added a comment - Stage View will have UI support for this once I cut the next release (the feature is merged in, I'm just waiting to cut a release until I can finish reviewing/testing the existing PRs). 

          James Dumay added a comment -

          cliffmeyers could you please take care of the frontend changes for this please? The implementation has been merged with master.

          James Dumay added a comment - cliffmeyers could you please take care of the frontend changes for this please? The implementation has been merged with master.

          James Dumay added a comment -

          cliffmeyers actually could you please pick this one ASAP? Theres some issues around wrapping rules here now that we've merged the work in

          ! #2 2017-06-05 10-50-45.png|thumbnail!

          James Dumay added a comment - cliffmeyers actually could you please pick this one ASAP? Theres some issues around wrapping rules here now that we've merged the work in ! #2 2017-06-05 10-50-45.png|thumbnail!

          Cliff Meyers added a comment -

          Merged to master and 1.1.0 branches.

          Cliff Meyers added a comment - Merged to master and 1.1.0 branches.

          Jakub Pawlinski added a comment - - edited

          How can I make custom description on step, i.e. replace the  "@echo Hello World — Windows Batch Script" blue ocean entry with "Hello World Step — Windows Batch Script" for:
          stages {
            stage('A') { 
              steps {
                bat "@echo Hello World"

                  }
              }
          }

          Jakub Pawlinski added a comment - - edited How can I make custom description on step, i.e. replace the  "@echo Hello World — Windows Batch Script" blue ocean entry with "Hello World Step — Windows Batch Script" for: stages {   stage('A') {       steps {       bat "@echo Hello World"         }     } }

          Michael Neale added a comment -

          Hi quas - best to ask that on a jenkins mailing list than a closed ticket. You can certainly make custom steps to do that but that is likely overkill. I am not sure if that is possible. 

          Michael Neale added a comment - Hi quas - best to ask that on a jenkins mailing list than a closed ticket. You can certainly make custom steps to do that but that is likely overkill. I am not sure if that is possible. 

          jake bishop added a comment -

          quas - we are also looking to do this. If you ask on a mailing list could you add a link to it here so that future people that browse here can also find it?

          jake bishop added a comment - quas - we are also looking to do this. If you ask on a mailing list could you add a link to it here so that future people that browse here can also find it?

          added my question to https://groups.google.com/forum/#!topic/jenkinsci-users/RzRvg8uELuA

          thanks for pointing this mailing lists out

          Jakub Pawlinski added a comment - added my question to https://groups.google.com/forum/#!topic/jenkinsci-users/RzRvg8uELuA thanks for pointing this mailing lists out

          Jesse Glick added a comment -

          How can I make custom description on step, i.e. replace the  "@echo Hello World — Windows Batch Script" blue ocean entry with "Hello World Step — Windows Batch Script"

          You cannot. This is not supported.

          Jesse Glick added a comment - How can I make custom description on step, i.e. replace the  "@echo Hello World — Windows Batch Script" blue ocean entry with "Hello World Step — Windows Batch Script" You cannot. This is not supported.

          Andrea Knight added a comment -

          Is is possible to have this information in the FlowGraphTable display of Rows?  We have so many rows and steps they are not being successfully by the BlueOcean. We exceed the numbers of branches that will be displayed.

          Andrea Knight added a comment - Is is possible to have this information in the FlowGraphTable display of Rows?  We have so many rows and steps they are not being successfully by the BlueOcean. We exceed the numbers of branches that will be displayed.

          Michael Neale added a comment -

          aknight1969 I think you are seeing: https://issues.jenkins-ci.org/browse/JENKINS-42781 - there is a limit of 100 (not often hit, but if you can add your notes to that ticket ,I will bump priority). 

          Michael Neale added a comment - aknight1969 I think you are seeing: https://issues.jenkins-ci.org/browse/JENKINS-42781  - there is a limit of 100 (not often hit, but if you can add your notes to that ticket ,I will bump priority). 

          Jesse Glick added a comment -

          Jesse Glick added a comment - aknight1969 try https://github.com/jenkinsci/workflow-support-plugin/pull/39  for that.

          Andrea Knight added a comment -

          jglick that is exactly what I am looking for.

          Unfortunately, I cannot incorporate the change into our production system until it is made available via a plugin.  I am looking forward to it being available.

           

          Thanks

                                                                                                     

          Andrea Knight added a comment - jglick that is exactly what I am looking for. Unfortunately, I cannot incorporate the change into our production system until it is made available via a plugin.  I am looking forward to it being available.   Thanks                                                                                            

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java
          src/main/resources/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn/column.jelly
          http://jenkins-ci.org/commit/workflow-support-plugin/862dbaedf528daeeb9a662417001bff1ac61ad3b
          Log:
          JENKINS-37324 Add an ArgumentsColumn to the FlowGraphTable display.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java src/main/resources/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn/column.jelly http://jenkins-ci.org/commit/workflow-support-plugin/862dbaedf528daeeb9a662417001bff1ac61ad3b Log: JENKINS-37324 Add an ArgumentsColumn to the FlowGraphTable display.

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java
          src/main/resources/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn/column.jelly
          http://jenkins-ci.org/commit/workflow-support-plugin/6515ef81f3a67cdfb0822206299d5a6f4cb2e7fc
          Log:
          Merge pull request #39 from jglick/ArgumentsColumn-JENKINS-37324

          JENKINS-37324 Add an ArgumentsColumn to the FlowGraphTable display

          Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/1074bea008ef...6515ef81f3a6

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java src/main/resources/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn/column.jelly http://jenkins-ci.org/commit/workflow-support-plugin/6515ef81f3a67cdfb0822206299d5a6f4cb2e7fc Log: Merge pull request #39 from jglick/ArgumentsColumn- JENKINS-37324 JENKINS-37324 Add an ArgumentsColumn to the FlowGraphTable display Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/1074bea008ef...6515ef81f3a6

          Andrea Knight added a comment -

          jglick when do you expect a release of the workflow-support-plugin that contains the new arguments column?

           

           

          Andrea Knight added a comment - jglick when do you expect a release of the workflow-support-plugin that contains the new arguments column?    

          Jesse Glick added a comment -

          aknight1969 I am not cutting releases. Up to abayer / svanoort. Or you can install a snapshot.

          Jesse Glick added a comment - aknight1969 I am not cutting releases. Up to abayer / svanoort . Or you can install a snapshot.

          Sam Van Oort added a comment -

          aknight1969 Tomorrow probably – we're holding off excess plugin releases today to avoid interference with additional release activity

          Sam Van Oort added a comment - aknight1969 Tomorrow probably – we're holding off excess plugin releases today to avoid interference with additional release activity

          Andrea Knight added a comment -

          I am using the latest version (2.20) of the Pipeline Supporting API plugin, and all dependencies are updated. I am not seeing the ArgumentsColumn feature.  Is there something that needs to be enabled to allow it to work?

          Andrea Knight added a comment - I am using the latest version (2.20) of the Pipeline Supporting API plugin, and all dependencies are updated. I am not seeing the ArgumentsColumn feature.  Is there something that needs to be enabled to allow it to work?

          Gil Shinar added a comment - - edited

          Can someone please help me understand which plugins should be installed (including versions) and what should I add to the pipeline to see the description?

          Gil Shinar added a comment - - edited Can someone please help me understand which plugins should be installed (including versions) and what should I add to the pipeline to see the description?

          James Dumay added a comment -

          gils I couldn't tell you exactly, but it should be the latest of everything required to run Blue Ocean and Blue Ocean itself.

          James Dumay added a comment - gils I couldn't tell you exactly, but it should be the latest of everything required to run Blue Ocean and Blue Ocean itself.

          James Dumay added a comment -

          Please do not pile any more comments on top of this issue. If you have specific problems or feature requests, please open other tickets or ask on the Jenkins Users mailing list.

          James Dumay added a comment - Please do not pile any more comments on top of this issue. If you have specific problems or feature requests, please open other tickets or ask on the Jenkins Users mailing list .

          How is this fixed? Via the new nested stages or a way to attach some label to any step will be actually added?

          Leandro Lucarella added a comment - How is this fixed? Via the new nested stages or a way to attach some label to any step will be actually added?

          Sam Van Oort added a comment -

          lucasocio It's fixed because steps now show the arguments used to run them (if they can be easily converted to strings or provide an implementation for it).

          Sam Van Oort added a comment - lucasocio It's fixed because steps now show the arguments used to run them (if they can be easily converted to strings or provide an implementation for it).

          Sam Van Oort added a comment -

          pustelni Please do not go around arbitrarily changing ticket statuses on other peoples' tickets – undoing this costs time we could be spending on making Jenkins better.

          Sam Van Oort added a comment - pustelni Please do not go around arbitrarily changing ticket statuses on other peoples' tickets – undoing this costs time we could be spending on making Jenkins better.

          Thales Pereira added a comment - - edited

          Hi cliffmeyers, this was implemented ? Or there's any alternative for this suggestion available for usage?

          Thales Pereira added a comment - - edited Hi cliffmeyers , this was implemented ? Or there's any alternative for this suggestion available for usage?

          If anyone is looking for a way to provide a custom label to a shell step, I've created this plugin that adds a labelledShell step which accepts a label argument: https://github.com/jenkinsci/labelled-steps-plugin/

          Vicky Chijwani added a comment - If anyone is looking for a way to provide a custom label to a shell step, I've created this plugin that adds a labelledShell step which accepts a label argument: https://github.com/jenkinsci/labelled-steps-plugin/

          Thales Pereira added a comment - - edited

          vchijwani You are a life saver, thank you. Let me know if you need help for maintaining it.

          Thales Pereira added a comment - - edited vchijwani You are a life saver, thank you. Let me know if you need help for maintaining it.

          Vicky Chijwani added a comment - - edited

          thclpr - I was thinking maybe we could add label support for other common steps as well. That's why I named the plugin labelled-steps instead of labelled-shell-step

          I don't know if it's going to be feasible / easy to support other steps, but it's worth a shot (sh step was thankfully trivial to modify). Hopefully at some point Jenkins core will support custom labels for any step.

          Vicky Chijwani added a comment - - edited thclpr - I was thinking maybe we could add label support for other common steps as well. That's why I named the plugin labelled-steps instead of labelled-shell-step I don't know if it's going to be feasible / easy to support other steps, but it's worth a shot (sh step was thankfully trivial to modify). Hopefully at some point Jenkins core will support custom labels for any step.

          Jesse Glick added a comment -

          This is Pipeline, not Jenkins core BTW.

          I still advocate maintaining a separation of duties, so that stage is used for adding a human-readable label to a step or sequence of steps. If Blue Ocean fails to display nested stages well, then improve Blue Ocean.

          Jesse Glick added a comment - This is Pipeline, not Jenkins core BTW. I still advocate maintaining a separation of duties, so that stage is used for adding a human-readable label to a step or sequence of steps. If Blue Ocean fails to display nested stages well, then improve Blue Ocean.

          jglick - you're right. I loosely said "Jenkins core" as a way to say "officially supported by CloudBees". If nested stages can support the use-case of labelling a group of steps (especially shell steps) without creating a new node in the pipeline visualization, that would also perfectly solve the issue.

          Come to think of it, there's a very similar proposal at JENKINS-44094, about grouping a set of steps with a custom label. That would solve multiple problems.

          Vicky Chijwani added a comment - jglick - you're right. I loosely said "Jenkins core" as a way to say "officially supported by CloudBees". If nested stages can support the use-case of labelling a group of steps (especially shell steps) without creating a new node in the pipeline visualization, that would also perfectly solve the issue. Come to think of it, there's a very similar proposal at JENKINS-44094 , about grouping a set of steps with a custom label. That would solve multiple problems.

          Still not sure that wrapping each and every "sh" step into a stage block is a good idea for providing a description for sh step.

          There should be a possibility to label sh step (and probably other steps) and it was mentioned here

          I had a plan to enhance "sh" step API and add "label" parameter (as discussed with svanoort). Just need to find time for that.

          Veaceslav Gaidarji added a comment - Still not sure that wrapping each and every "sh" step into a stage block is a good idea for providing a description for sh step. There should be a possibility to label sh step (and probably other steps) and it was mentioned here .  I had a plan to enhance "sh" step API and add "label" parameter (as discussed with svanoort ). Just need to find time for that.

          Dana Goyette added a comment - - edited

          As it is now, the sh script is quite unreliable about ever saying anything more than just "Shell Script". 
          Shouldn't single-line commands show the command being executed? For me, they almost never do.

          These steps show the command:
          sh(script: "/usr/bin/env python ./install_manager.py --jenkins --uninstall-all")
          sh(script: "/usr/bin/env python ./install_manager.py --jenkins --fail-if-leftovers --uninstall-all")

          These steps show just "Shell Script", rendering the summary useless:
          sh(script: "/usr/bin/env python ./install_manager.py --jenkins --build-id 123456 --install")
          sh(script: "/usr/bin/env python ./install_manager.py --jenkins --build-id 123456 --uninstall")
          Adding or removing the /usr/bin/env didn't change anything, either.

          Note that my actual script is actually calling sh with a Map as a parameter, rather than passing named parameters.
          If I use the labelledShell step, even that description sometimes gets ignored.

           

          Dana Goyette added a comment - - edited As it is now, the sh script is quite unreliable about ever saying anything more than just "Shell Script".  Shouldn't single-line commands show the command being executed? For me, they almost never do. These steps show the command: sh(script: "/usr/bin/env python ./install_manager.py --jenkins --uninstall-all") sh(script: "/usr/bin/env python ./install_manager.py --jenkins --fail-if-leftovers --uninstall-all") These steps show just "Shell Script", rendering the summary useless: sh(script: "/usr/bin/env python ./install_manager.py --jenkins --build-id 123456 --install") sh(script: "/usr/bin/env python ./install_manager.py --jenkins --build-id 123456 --uninstall") Adding or removing the /usr/bin/env didn't change anything, either. Note that my actual script is actually calling sh with a Map as a parameter, rather than passing named parameters. If I use the labelledShell step, even that description sometimes gets ignored.  

          Phil McArdle added a comment -

          danagoyette, I haven't tested this in a while, but I believe your issue there is using variables like the build id, assuming you used the actual number of the current build. In my experience, Jenkins goes to lengths to identify and mask data like that.

          Phil McArdle added a comment - danagoyette , I haven't tested this in a while, but I believe your issue there is using variables like the build id, assuming you used the actual number of the current build. In my experience, Jenkins goes to lengths to identify and mask data like that.

          Dana Goyette added a comment -

          Thanks for the hint about the issue being variables. That seems to be it: if I use any variables (in the stock sh step's command or the labelledShell step's label), then the label is just silently ignored! Should I file a separate ticket for that brokenness?

          Dana Goyette added a comment - Thanks for the hint about the issue being variables. That seems to be it: if I use any variables (in the stock sh step's command or the labelledShell step's label), then the label is just silently ignored! Should I file a separate ticket for that brokenness?

          Phil McArdle added a comment -

          If you wanted something like that changed, that'd be a separate issue, yep

          I think that's running at a much lower level than the step labelling.

          Phil McArdle added a comment - If you wanted something like that changed, that'd be a separate issue, yep I think that's running at a much lower level than the step labelling.

          Jesse Glick added a comment -

          if I use any variables (in the stock sh step's command or the labelledShell step's label), then the label is just silently ignored

          See JENKINS-47101.

          Jesse Glick added a comment - if I use any variables (in the stock sh step's command or the labelledShell step's label), then the label is just silently ignored See JENKINS-47101 .

          boris avney added a comment -

          Hi,

          Where can I find which BO version has this functionality?
          (couldn't find the PR in change log: https://wiki.jenkins.io/display/JENKINS/Blue+Ocean+Plugin)

           

          boris avney added a comment - Hi, Where can I find which BO version has this functionality? (couldn't find the PR in change log:  https://wiki.jenkins.io/display/JENKINS/Blue+Ocean+Plugin)  

            cliffmeyers Cliff Meyers
            jamesdumay James Dumay
            Votes:
            24 Vote for this issue
            Watchers:
            52 Start watching this issue

              Created:
              Updated:
              Resolved: