Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47214

Give ability to opt out of autofavoriting

    XMLWordPrintable

Details

    • Blue Ocean 1.4 - beta 3

    Description

      I am maintaining a global library for our Jenkins which gets used by a few hundred projects. Due to that the autofavorite plugin favorites pretty much every job on our Jenkins for me. This causes issues, such as JENKINS-44995.

      I assumed that JENKINS-41497 would solve the issue, since I will no longer be in the SCM changes, however it does not.

      Regardless of if library changes should trigger autofavoriting, an option for a user to opt out of autofavoriting would be beneficial.

      Attachments

        Issue Links

          Activity

            jamesdumay James Dumay added a comment -

            schulzha I've also added another PR that provides this function as a global system property https://github.com/jenkinsci/blueocean-autofavorite-plugin/pull/13

            jamesdumay James Dumay added a comment - schulzha I've also added another PR that provides this function as a global system property https://github.com/jenkinsci/blueocean-autofavorite-plugin/pull/13

            Code changed in jenkins
            User: James William Dumay
            Path:
            src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java
            src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java
            http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/80930fe881c6b738a452e3f018c81b53b18f0fb6
            Log:
            JENKINS-47214 globally disable autofavorite using system property (#13)

            -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/80930fe881c6b738a452e3f018c81b53b18f0fb6 Log: JENKINS-47214 globally disable autofavorite using system property (#13) -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false
            schulzha Hans Schulz added a comment -

            jamesdumay I've installed the update yesterday and no autofavorites so far! Great fix, thanks!

            The system oproperty seems useful and I will try it out once its in the next release.

            schulzha Hans Schulz added a comment - jamesdumay I've installed the update yesterday and no autofavorites so far! Great fix, thanks! The system oproperty seems useful and I will try it out once its in the next release.
            jamesdumay James Dumay added a comment -

            schulzha system property was added in 1.2.1 which was released to the update center

            jamesdumay James Dumay added a comment - schulzha system property was added in 1.2.1 which was released to the update center
            kshultz Karl Shultz added a comment -

            Testing Notes:
            A test for this is already part of the PR.

            kshultz Karl Shultz added a comment - Testing Notes: A test for this is already part of the PR .

            People

              jamesdumay James Dumay
              schulzha Hans Schulz
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: