• Blue Ocean 1.4 - beta 3

      I am maintaining a global library for our Jenkins which gets used by a few hundred projects. Due to that the autofavorite plugin favorites pretty much every job on our Jenkins for me. This causes issues, such as JENKINS-44995.

      I assumed that JENKINS-41497 would solve the issue, since I will no longer be in the SCM changes, however it does not.

      Regardless of if library changes should trigger autofavoriting, an option for a user to opt out of autofavoriting would be beneficial.

          [JENKINS-47214] Give ability to opt out of autofavoriting

          James Dumay added a comment -

          Code is ready for review

          James Dumay added a comment - Code is ready for review

          Michael Neale added a comment -

          PR looks good - this is worth a try - may help a bunch of folks

          Michael Neale added a comment - PR looks good - this is worth a try - may help a bunch of folks

          Code changed in jenkins
          User: James William Dumay
          Path:
          src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java
          src/main/java/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty.java
          src/main/resources/io/jenkins/blueocean/autofavorite/Messages.properties
          src/main/resources/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty/config.jelly
          src/main/resources/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty/config.properties
          src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java
          http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/45f6a79e76632e9a785c392662785a8c1c42d933
          Log:
          JENKINS-47214 Give ability to opt out of autofavoriting (#12)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java src/main/java/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty.java src/main/resources/io/jenkins/blueocean/autofavorite/Messages.properties src/main/resources/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty/config.jelly src/main/resources/io/jenkins/blueocean/autofavorite/user/FavoritingUserProperty/config.properties src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/45f6a79e76632e9a785c392662785a8c1c42d933 Log: JENKINS-47214 Give ability to opt out of autofavoriting (#12)

          James Dumay added a comment - - edited

          Released as 1.2.0

          Should take a few hours to get into the update center.

          James Dumay added a comment - - edited Released as 1.2.0 Should take a few hours to get into the update center.

          Code changed in jenkins
          User: James Dumay
          Path:
          src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java
          src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java
          http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/0bf368e9d9b757e7c15efccaf2eb71c472a7cb44
          Log:
          JENKINS-47214 globally disable autofavorite using system property

          -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/0bf368e9d9b757e7c15efccaf2eb71c472a7cb44 Log: JENKINS-47214 globally disable autofavorite using system property -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false

          James Dumay added a comment -

          schulzha I've also added another PR that provides this function as a global system property https://github.com/jenkinsci/blueocean-autofavorite-plugin/pull/13

          James Dumay added a comment - schulzha I've also added another PR that provides this function as a global system property https://github.com/jenkinsci/blueocean-autofavorite-plugin/pull/13

          Code changed in jenkins
          User: James William Dumay
          Path:
          src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java
          src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java
          http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/80930fe881c6b738a452e3f018c81b53b18f0fb6
          Log:
          JENKINS-47214 globally disable autofavorite using system property (#13)

          -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java src/test/java/io/jenkins/blueocean/autofavorite/FavoritingScmListenerTest.java http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/80930fe881c6b738a452e3f018c81b53b18f0fb6 Log: JENKINS-47214 globally disable autofavorite using system property (#13) -DBLUEOCEAN_FEATURE_AUTOFAVORITE_ENABLED=false

          Hans Schulz added a comment -

          jamesdumay I've installed the update yesterday and no autofavorites so far! Great fix, thanks!

          The system oproperty seems useful and I will try it out once its in the next release.

          Hans Schulz added a comment - jamesdumay I've installed the update yesterday and no autofavorites so far! Great fix, thanks! The system oproperty seems useful and I will try it out once its in the next release.

          James Dumay added a comment -

          schulzha system property was added in 1.2.1 which was released to the update center

          James Dumay added a comment - schulzha system property was added in 1.2.1 which was released to the update center

          Karl Shultz added a comment -

          Testing Notes:
          A test for this is already part of the PR.

          Karl Shultz added a comment - Testing Notes: A test for this is already part of the PR .

            jamesdumay James Dumay
            schulzha Hans Schulz
            Votes:
            2 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: