Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59427

Rename SSH Slaves Plugin

    XMLWordPrintable

Details

    • ssh-slaves-1.31.1

    Description

      It is a follow-up to JENKINS-42840. The plugin doucmentation has been updated to avoid "slaves", but we still have "slave" right in the plugin name. We need to rename it without touching artifactId. It will require README and pom.xml cleanup, and also additional documentation review.

      Possible name options:

       

      Attachments

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev added a comment -

            I would like to mention that SSH Nodes Plugin is not fully correct, because "Node" defines both local and remote executors (hehe, "Nodes"). Agent defines remote ones, but we cannot just call the plugin "SSH Agents Plugin" because of the confusion with ssh-agent. Hence there are options.

             

            Running a poll in Twitter: https://twitter.com/oleg_nenashev/status/1210146423888633861

             

            CC ifernandezcalvo

            oleg_nenashev Oleg Nenashev added a comment - I would like to mention that SSH Nodes Plugin is not fully correct, because "Node" defines both local and remote executors (hehe, "Nodes"). Agent defines remote ones, but we cannot just call the plugin "SSH Agents Plugin" because of the confusion with ssh-agent. Hence there are options.   Running a poll in Twitter:  https://twitter.com/oleg_nenashev/status/1210146423888633861   CC ifernandezcalvo
            oleg_nenashev Oleg Nenashev added a comment -

            So my conclusion is that there is a mess in plugin naming already. We either stick to the "Foo Agents Plugin" terminology, or steer naming to "Foo Agent Launcher" or "Foo Node Launcher". The latter one is more developer-friendly, because the actual extension point under the hood is "NodeLauncher". My sugestion would be to proceed with "SSH Build Agents" or "SSH Node Launcher Plugin".

            ifernandezcalvo could you please select the final name as a maintainer?

             

             

            oleg_nenashev Oleg Nenashev added a comment - SSH Build Agents is a winner according to the poll. There were very valid concerns about using "Build" in the name, e.g. from brantone There were suggestions from martinda to take a look at other existing names https://plugins.jenkins.io/windows-slaves  was renamed to "WMI Windows Agents Plugin" https://plugins.jenkins.io/azure-vm-agents https://plugins.jenkins.io/command-launcher In the comments there were few extra options we could consider: "SSH Node Launcher Plugin" by esmalling , "Agent launcher via SSH plugin" by teilo So my conclusion is that there is a mess in plugin naming already. We either stick to the "Foo Agents Plugin" terminology, or steer naming to "Foo Agent Launcher" or "Foo Node Launcher". The latter one is more developer-friendly, because the actual extension point under the hood is "NodeLauncher". My sugestion would be to proceed with "SSH Build Agents" or "SSH Node Launcher Plugin". ifernandezcalvo could you please select the final name as a maintainer?    
            esmalling Eric Smalling added a comment -

            FWIW, I think "SSH Build Agents" is a fine choice too.

            esmalling Eric Smalling added a comment - FWIW, I think "SSH Build Agents" is a fine choice too.

            the poll winner is fine "SSH Build Agents"

            ifernandezcalvo Ivan Fernandez Calvo added a comment - the poll winner is fine "SSH Build Agents"
            oleg_nenashev Oleg Nenashev added a comment -

            So be it. Just in case, we can always rename it again

            oleg_nenashev Oleg Nenashev added a comment - So be it. Just in case, we can always rename it again
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/ssh-slaves-plugin/pull/169

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: