Details
-
Type:
Improvement
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: ssh-slaves-plugin
-
Labels:
-
Similar Issues:
-
Epic Link:
-
Released As:ssh-slaves-1.31.1
Description
It is a follow-up to JENKINS-42840. The plugin doucmentation has been updated to avoid "slaves", but we still have "slave" right in the plugin name. We need to rename it without touching artifactId. It will require README and pom.xml cleanup, and also additional documentation review.
Possible name options:
- SSH Nodes Plugins (Ivan Fernandez Calvo)
- SSH Agent Nodes Plugin (Ivan Fernandez Calvo)
- SSH Build Agents Plugin (Oleg Nenashev)
Attachments
Issue Links
- is related to
-
-
- Resolved
-
Activity
- SSH Build Agents is a winner according to the poll.
- There were very valid concerns about using "Build" in the name, e.g. from Brantone
- There were suggestions from Martin d'Anjou to take a look at other existing names
- https://plugins.jenkins.io/windows-slaves was renamed to "WMI Windows Agents Plugin"
- https://plugins.jenkins.io/azure-vm-agents
- https://plugins.jenkins.io/command-launcher
- In the comments there were few extra options we could consider: "SSH Node Launcher Plugin" by Eric Smalling, "Agent launcher via SSH plugin" by James Nord
So my conclusion is that there is a mess in plugin naming already. We either stick to the "Foo Agents Plugin" terminology, or steer naming to "Foo Agent Launcher" or "Foo Node Launcher". The latter one is more developer-friendly, because the actual extension point under the hood is "NodeLauncher". My sugestion would be to proceed with "SSH Build Agents" or "SSH Node Launcher Plugin".
Ivan Fernandez Calvo could you please select the final name as a maintainer?
FWIW, I think "SSH Build Agents" is a fine choice too. 
the poll winner is fine "SSH Build Agents" 
So be it. Just in case, we can always rename it again
I would like to mention that SSH Nodes Plugin is not fully correct, because "Node" defines both local and remote executors (hehe, "Nodes"). Agent defines remote ones, but we cannot just call the plugin "SSH Agents Plugin" because of the confusion with ssh-agent. Hence there are options.
Running a poll in Twitter: https://twitter.com/oleg_nenashev/status/1210146423888633861
CC Ivan Fernandez Calvo