• sshd-3.0.4

      Some of the libraries that Jenkins uses (e.g. JGit) have moved on to use SSHD 2.x. This contains breaking changes. But sshd-module still expects SSHD 1.x. The incompatibilities cause either compile-time or runtime 'class not found' errors in Jenkins and its plugins.

      We need to bump our SSHD dependencies to fix this.

      Options:

      • SSHD 2.2.0 (also used by the current release of JGit)
      • SSHD 2.3.0 (the very latest version)

      Affected downstream components:

      • Gerrit Trigger plugin
      • git-server plugin
      • Jenkins Core CLI
      • Remote terminal access plugin
      • ...

          [JENKINS-60902] Upgrade sshd-module to use SSHD 2.x

          Oleg Nenashev added a comment -

          3.0 for sure if it remains a module. I am rather tempted to merge https://github.com/jenkinsci/sshd-module/pull/29 from jglick and move it to the plugin entirely before bumping the dependency, but it will require bumps to recent Jenkins core versions in all dependent plugins to get the issue fixed. Not sure what would rsandell say about Gerrit trigger

          Oleg Nenashev added a comment - 3.0 for sure if it remains a module. I am rather tempted to merge  https://github.com/jenkinsci/sshd-module/pull/29  from jglick and move it to the plugin entirely before bumping the dependency, but it will require bumps to recent Jenkins core versions in all dependent plugins to get the issue fixed. Not sure what would rsandell say about Gerrit trigger

          Jesse Glick added a comment -

          Is there some urgency here?

          The incompatibilities cause either compile-time or runtime 'class not found' errors in Jenkins and its plugins.

          Do you mean that these incompatibilities would cause such errors were we to carelessly update, say, the git-client plugin’s dependency? Or that there are such errors for users today?

          Jesse Glick added a comment - Is there some urgency here? The incompatibilities cause either compile-time or runtime 'class not found' errors in Jenkins and its plugins. Do you mean that these incompatibilities would cause such errors were we to carelessly update, say, the git-client plugin’s dependency? Or that there are such errors for users today?

          Chris Kilding added a comment -

          Let’s say not an immediate urgency but perhaps a medium-term one...

          I get those errors in my plugin today, but fortunately only in tests: this is because the JGit SSH JUnit helper lib pulls in SSHD 2.2.0. It doesn’t affect my plugin in operation as I don’t need JGit in compile scope.

          But a plugin that does need a recent JGit version in compile scope would be affected today.

          Chris Kilding added a comment - Let’s say not an immediate urgency but perhaps a medium-term one... I get those errors in my plugin today, but fortunately only in tests: this is because the JGit SSH JUnit helper lib pulls in SSHD 2.2.0. It doesn’t affect my plugin in operation as I don’t need JGit in compile scope. But a plugin that does need a recent JGit version in compile scope would be affected today.

          Oleg Nenashev added a comment -

          Just an update here, 2.222.x LTS has happened recently. If we want to land an incompatible change, it would be great to do so in one month or so so that we can get plugins verified and, if needed, fixed before the next LTS

          Oleg Nenashev added a comment - Just an update here, 2.222.x LTS has happened recently. If we want to land an incompatible change, it would be great to do so in one month or so so that we can get plugins verified and, if needed, fixed before the next LTS

          chriskilding Are you still working on this? if not, I would like to continue from here, I want to convert the module in a plugin(JENKINS-55582) and bump the library

          Ivan Fernandez Calvo added a comment - chriskilding Are you still working on this? if not, I would like to continue from here, I want to convert the module in a plugin( JENKINS-55582 ) and bump the library

          Chris Kilding added a comment -

          I removed the test where I was using the Git-over-SSH functionality a while back, which allowed me to remove the Git plugin and SSHD plugin from my own plugin's manifest. (This was a crude way of solving the problem but it did work...)

          As a result I'm happy for anyone to take this work in a different direction.

          Chris Kilding added a comment - I removed the test where I was using the Git-over-SSH functionality a while back, which allowed me to remove the Git plugin and SSHD plugin from my own plugin's manifest. (This was a crude way of solving the problem but it did work...) As a result I'm happy for anyone to take this work in a different direction.

          Matt Sicker added a comment -

          Adding to Mina SSH epic.

          Matt Sicker added a comment - Adding to Mina SSH epic.

          Ivan Fernandez Calvo added a comment - - edited

          Ivan Fernandez Calvo added a comment - - edited This is the list of plugins affected by the change of package of the class Command Active plugins https://github.com/jenkinsci/git-server-plugin https://github.com/jenkinsci/gerrit-trigger-plugin https://github.com/jenkinsci/ssh-agent-plugin outdated plugins https://github.com/jenkinsci/remote-terminal-access-plugin - 7 years https://github.com/jenkinsci/ssh-cli-plugin - 9 years

          Ivan Fernandez Calvo added a comment - plugins to make a PR to test the update https://github.com/jenkinsci/scriptler-plugin https://github.com/jenkinsci/matrix-project-plugin https://github.com/jenkinsci/jsch-plugin https://github.com/jenkinsci/electricflow-plugin https://github.com/jenkinsci/git-server-plugin https://github.com/jenkinsci/gerrit-trigger-plugin https://github.com/jenkinsci/ssh-agent-plugin

          batmat this issue is not merged so it is not the cause of any regression, I think you were looking for the issue https://issues.jenkins.io/browse/JENKINS-65273 that it is caused by https://github.com/jenkinsci/jenkins/commit/4d818c294fb9838902ed9e42e022f93f1cb0c9cc#diff-99bb88401742848e032fd6f51709415fb6be169a72d2e5d7fc44289255160d3c that bumps the sshd-core library in the Jenkins CLI

          Ivan Fernandez Calvo added a comment - batmat this issue is not merged so it is not the cause of any regression, I think you were looking for the issue https://issues.jenkins.io/browse/JENKINS-65273 that it is caused by https://github.com/jenkinsci/jenkins/commit/4d818c294fb9838902ed9e42e022f93f1cb0c9cc#diff-99bb88401742848e032fd6f51709415fb6be169a72d2e5d7fc44289255160d3c that bumps the sshd-core library in the Jenkins CLI

            ifernandezcalvo Ivan Fernandez Calvo
            chriskilding Chris Kilding
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: