Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Won't Do
-
Component/s: github-branch-source-plugin
-
Labels:None
-
Similar Issues:
Description
Currently GitHubAppCredentials is generating JWT token from the AppInstallationToken, I think only in few exceptional cases AppInstallationToken is needed.
We need to convert the logic to use the JWT token itself to support it across multiple organizations.
Given there are no issues with this implementation, this could solve other issues like JENKINS-64662 and JENKINS-62220.
JWT Token vs App Installation Token
https://github-api.kohsuke.org/githubappjwtauth.html
https://github-api.kohsuke.org/githubappappinsttokenauth.html
Attachments
Issue Links
- is related to
-
JENKINS-62220 GitHub App to support credentials with multiple organizations
-
- Open
-
-
JENKINS-64662 Create GitHub App Credentials Binding to support owner override
-
- In Review
-
Nvm, I got this wrong, we need to get app before we actually create access token, jwt are only meant to authenticate app and then from app installation token we get the actual access token. Closing.