Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62220

GitHub App to support credentials with multiple organizations

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      We are trying to use same app on Jobs across orgs and is not working as we need to maintain duplicate credentials for multiple organization.

      Maintaining same credentials for multiple orgs seems duplicate to me, is there any chance we can avoid this?

      Our use case is, since it is internal (GitHub Enterprise) bot, it is pretty open and we don't even know who would invite this bot to their organization, and this bot does takes care of creating Jenkins job through DSL scripts, which is using the standard credentials. So it is very hard to keep creating credentials on the fly for every org that this bot is being invited to.

      Thanks a bunch for all the help on maintaining this awesome plugin. Let me know your thoughts please.

      Related discussion on PR: https://github.com/jenkinsci/github-branch-source-plugin/pull/290#discussion_r415168275

        Attachments

          Issue Links

            Activity

            Hide
            dileep626 Dileep Reddy added a comment -

            This is really a problem. We have to configure multiple credentials for multiple organizations. And everytime, we install on a new org, we need to make sure its credentials are created too.

            This is a problem especially with plugins that need app-only creds (e.g: github-checks plugin).

            Is there a workaround for this?

            Show
            dileep626 Dileep Reddy added a comment - This is really a problem. We have to configure multiple credentials for multiple organizations. And everytime, we install on a new org, we need to make sure its credentials are created too. This is a problem especially with plugins that need app-only creds (e.g: github-checks plugin). Is there a workaround for this?
            Hide
            nrayapati Naresh Rayapati added a comment -

            Created https://issues.jenkins.io/browse/JENKINS-64662 to support owner override through withCredentails to support other use pipeline use cases.

            Show
            nrayapati Naresh Rayapati added a comment - Created https://issues.jenkins.io/browse/JENKINS-64662  to support owner override through withCredentails to support other use pipeline use cases.
            Hide
            llibicpep Dmytro Kryvenko added a comment -

            I just thought of another issue related to this. Consider a pipeline that needs access to more than one org simultaneously. It might be a Go module or a Terraform module that reaching out for dependencies - nothing fancy, totally legit use case. Pipeline is not aware of what the underlying tool will try to reach, but as long as the GitHub App is authorized in all of the orgs - it should be possible to do that.
            My understanding is it's currently not and it's probably on GitHub side? What's the alternative, deprecating services and etc - it seems like GitHub Apps are the only recommended one auth type?

            Show
            llibicpep Dmytro Kryvenko added a comment - I just thought of another issue related to this. Consider a pipeline that needs access to more than one org simultaneously. It might be a Go module or a Terraform module that reaching out for dependencies - nothing fancy, totally legit use case. Pipeline is not aware of what the underlying tool will try to reach, but as long as the GitHub App is authorized in all of the orgs - it should be possible to do that. My understanding is it's currently not and it's probably on GitHub side? What's the alternative, deprecating services and etc - it seems like GitHub Apps are the only recommended one auth type?
            Hide
            nrayapati Naresh Rayapati added a comment - - edited

            Looks like currently GitHubAppCredentials is using app installation token, not sure of the actual/initial design notes, probably if we convert it to use the JWToken to avoid the issue reported in this JIRA. 

            Logged a new Jira for that:
            https://issues.jenkins.io/browse/JENKINS-64870 

            JWT Token vs App Installation Token
            https://github-api.kohsuke.org/githubappjwtauth.html
            https://github-api.kohsuke.org/githubappappinsttokenauth.html

            Show
            nrayapati Naresh Rayapati added a comment - - edited Looks like currently GitHubAppCredentials is using app installation token, not sure of the actual/initial design notes, probably if we convert it to use the JWToken to avoid the issue reported in this JIRA.  Logged a new Jira for that: https://issues.jenkins.io/browse/JENKINS-64870   JWT Token vs App Installation Token https://github-api.kohsuke.org/githubappjwtauth.html https://github-api.kohsuke.org/githubappappinsttokenauth.html
            Hide
            llibicpep Dmytro Kryvenko added a comment -

            I'm pretty sure we need support for both. Certain use cases will need it exactly the way it is currently implemented. Consider a case with 3 independent parties - end users of jenkins (owners of orgs/repos), app owner (owner of jenkins installation) and github. In certain scenarios you will want to use same GitHub app to authenticate Jenkins installation but still prevent different Jenkins end-users via their pipelines to be able to meddle with each other.

            Show
            llibicpep Dmytro Kryvenko added a comment - I'm pretty sure we need support for both. Certain use cases will need it exactly the way it is currently implemented. Consider a case with 3 independent parties - end users of jenkins (owners of orgs/repos), app owner (owner of jenkins installation) and github. In certain scenarios you will want to use same GitHub app to authenticate Jenkins installation but still prevent different Jenkins end-users via their pipelines to be able to meddle with each other.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              nrayapati Naresh Rayapati
              Votes:
              2 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated: